[squeak-dev] The Inbox: Tools-LM.829.mcz

David T. Lewis lewis at mail.msen.com
Fri Aug 17 16:37:01 UTC 2018


Thanks Tim,

This sounds like Tools-tcj.827.mcz in the inbox. I had not intended to
include that in this merge, but I may have done so by accident.

Chris, if you're looking at this, please say if you think the two methods
from Tools-tcj.827 belong in trunk. If yes, we can move Tools-tcj.827.mcz
to trunk so that the record is complete; if no, the two methods can be
reverted and considered later after the 5.2 release.

Dave


>
>
>> On Aug 16, 2018, at 2:41 PM, Chris Muller <asqueaker at gmail.com> wrote:
>>
>>> +1.  Merge now.  It won’t break anything.
>>
>> The date on the methods is _yesterday_, are you really comfortable
>> making such a statement?
>>
>> So what about FileContentsBrowser>>#browseVersions?  Looks like it was
>> rolled back to Doug Way's version from 2000 to no longer use your
>> 2016 update to use ToolSet.  But please, just let me know, don't
>> commit any more versions yet, 'cuz I see some other issues..
>
> This sounds like a contribution I made.  #browseVersions in
> FileContentsBrowser cannot use the 2016 update to use ToolSet.  It doesn't
> work.  Try it for yourself.
>
> Reverting to the 2000 version allows it to work again.
>
> Cheers,
> Tim
>
>
>




More information about the Squeak-dev mailing list