[squeak-dev] The Trunk: Monticello-ul.679.mcz

Tobias Pape Das.Linux at gmx.de
Fri Mar 23 08:42:04 UTC 2018


> On 23.03.2018, at 01:05, Levente Uzonyi <leves at caesar.elte.hu> wrote:
> 
> Hi Tobias,
> 
> When WebClient was added, HTTPSocket was modified to use WebClient when it's present, but still work when it's not. I simply followed that path.
> WebClient still has no dependencies in the Trunk, so one should be able to
> safely unload it.

I think Chris Muller went ahead and changed that in HTTPSocket so that it is now no longer possible to remove it…
(see protocol *webclient-http in HTTPSocket class)
But I maybe wrong. Maybe it was already the case when we fully loaded webclient, we probably killed the HTTPRequestHandler functionality.


Thus, if we unload WebClient, everything using HTTPSocket already breaks…

HTTPSocket is now merely a
 - shim for WebClient
 - holder of various, maybe dubious, preferences and data
 - The only thing that knows what a HTTPBlabEmail is for (w.t.h...)

Best regards
	-Tobias


> But sure, we can just "nuke" HTTPSocket & co. in favor of WebClient.
> 
> Levente
> 
> On Thu, 22 Mar 2018, Tobias Pape wrote:
> 
>> Hi Levente
>> 
>> 
>> I really like the reuse-idea.
>> Also, WebClient is part of Squeak/Trunk since 4.5 I think. I think it is safe to assume that it's there. Let's rather completely deprecate HTTPSocket instead :)
>> 
>> Best regards
>> 	-Tobias
>>> On 22.03.2018, at 19:33, commits at source.squeak.org wrote:
>>> Levente Uzonyi uploaded a new version of Monticello to project The Trunk:
>>> http://source.squeak.org/trunk/Monticello-ul.679.mcz
>>> ==================== Summary ====================
>>> Name: Monticello-ul.679
>>> Author: ul
>>> Time: 22 March 2018, 7:32:51.372118 pm
>>> UUID: 7f5a3bf7-0cda-4200-b035-d9ce789f19d5
>>> Ancestors: Monticello-ul.678
>>> - enable #useSharedWebClientInstance by default when WebClient is present
>>> =============== Diff against Monticello-ul.678 ===============
>>> Item was changed:
>>> ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') -----
>>> useSharedWebClientInstance
>>> 
>>> 	<preference: 'Use shared WebClient instance'
>>> 		category: 'Monticello'
>>> 		description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.'
>>> 		type: #Boolean>
>>> + 	^UseSharedWebClientInstance ifNil: [ Smalltalk hasClassNamed: #WebClient ]!
>>> - 	^UseSharedWebClientInstance ifNil: [ false ]!
>>> 
> 



More information about the Squeak-dev mailing list