[squeak-dev] [Please Test] Refactoring for BorderedMorph to use BorderStyle

Marcel Taeumel marcel.taeumel at hpi.de
Fri May 4 14:49:08 UTC 2018


Well, I did more changes than expected. Please find attached the current version of that refactoring and test again. Note that we have, at the moment, no support for rounded corners in inset/raised borders.

Best,
Marcel
Am 04.05.2018 10:34:20 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
I will merge that refactoring during the next hours. Please report any issues here and not as a response to the commit e-mails.

Best,
Marel
Am 11.04.2018 12:01:47 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Hi, there.

Please find attached a refactoring of BorderedMorph to make use of BorderStyle like regular morphs do. Maybe, in the future, we can get rid of BorderedMorph.

It includes:
- No instVar access to borderColor and borderWidth but message sends.
- No #inset or #raised anymore when asking a morph for its #borderColor. Just colors.
- Copying the prototypical border styles from the UI theme when used in morphs.
- A post-load script that updates all your morphs in the image. Not that important but good for keeping your current tools opened.

After a few days of no complaints, I will merge it into Trunk.

Best,
Marcel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20180504/b1c1becf/attachment-0001.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: border-layout.11.cs
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20180504/b1c1becf/attachment-0001.ksh>


More information about the Squeak-dev mailing list