[squeak-dev] The Trunk: WebClient-Core-pre.117.mcz
leves at caesar.elte.hu
Tue Sep 18 10:45:03 UTC 2018
One more thing to consider is uploads. While these methods are
currently not used by WebRequest, it is possible to do so, and in such
case my suggestion would remove the progress indicator, which is something
we don't want.
So, I suggest to push this as-is, and review these methods after the
On Tue, 18 Sep 2018, patrick.rein at hpi.uni-potsdam.de wrote:
>>> + self streamDirectlyFrom: content readStream to: dstStream size: size progress: aBlock
>>> - self streamFrom: content readStream to: dstStream size: size progress: aBlock
>> It seems to me that this is the only real change. And if I'm not
>> mistaken, that could simply be written as
>> dstStream nextPutAll: content
>> Which would be simpler and way more efficient.
> Yes, absolutely. My rational for that solution was to change as little as possible of the current control flow. After digging through various parts of the streamFrom:to: protocol (together with Tobias) we figured out that there are various inconsistent uses of the methods, in particular as WebChunkedStream exists but is not used. Thus, in order to not violate any assumptions of potential clients, I tried to preserve the control flow and added the flag for a potential refactoring after the 5.2 release.
> That being said and after looking at the streamDirectlyFrom:to:size:progress: message again carefully: I will change it to your proposed version :) It might take till the European afternoon though for me to upload it.
More information about the Squeak-dev