[squeak-dev] The Inbox: Morphic-mt.1601.mcz
Chris Muller
asqueaker at gmail.com
Fri Dec 6 21:29:07 UTC 2019
-1. I couldn't stand a similar feature in Pharo, where selecting "browse"
on something would try really hard to produce "something" if it couldn't
find a class, it'd try implementors.
"Implementors" is used when I want to trace message flow throug a system,
this is _totally different_ than browsing the behaviors of a class.
Unifying these two things in the IDE under one command is detrimental.
Please don't do it or, if you must, please protect the current function
with a preference.
Best,
Chris
On Wed, Dec 4, 2019 at 9:16 AM Eliot Miranda <eliot.miranda at gmail.com>
wrote:
> Hi Marcel,
>
>
> > On Dec 4, 2019, at 6:15 AM, commits at source.squeak.org wrote:
> >
> > A new version of Morphic was added to project The Inbox:
> > http://source.squeak.org/inbox/Morphic-mt.1601.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Morphic-mt.1601
> > Author: mt
> > Time: 4 December 2019, 3:14:52.073613 pm
> > UUID: 19583b0d-de7d-45e3-bf18-c4b7b2690b47
> > Ancestors: Morphic-mt.1600
> >
> > Proposal: For "implementors of it!" on class bindings or class-var
> bindings or other global bindings, browse the underlying class of it. For
> the user's convenience. At the moment, implementors-of-it on such bindings
> does simply nothing.
>
> +100 for the functionality. But I would definitely call “browseClass:”
> something different such as “browseClassOrPoolDefining:”. The binding could
> be that of a class or of a class/pool variable. browseClass: isn’t a good
> name and if it just browses classes that are the values of bindings it
> isn’t that useful.
>
> The vm contains a number of pools, the largest of which defines the
> opcodes in the JIT’s abstract machine. So my WiFi’s is full of bindings
> other than those that define classes.
>
>
> > =============== Diff against Morphic-mt.1600 ===============
> >
> > Item was changed:
> > ----- Method: TextEditor>>implementorsOfIt (in category 'menu
> messages') -----
> > implementorsOfIt
> > + "Open an implementors browser on the selected selector or a regular
> browser if the selection is a class binding."
> > +
> > - "Open an implementors browser on the selected selector"
> > - | aSelector |
> > self lineSelectAndEmptyCheck: [^ self].
> > + self selectedBinding ifNotNil:
> > + [:binding | ^ self systemNavigation browseClass: binding].
> > + self selectedSelector ifNotNil:
> > + [:selector | ^ self systemNavigation browseAllImplementorsOf:
> selector].
> > + morph flash!
> > - (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].
> > - model browseAllImplementorsOf: aSelector!
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191206/0cb53efa/attachment.html>
More information about the Squeak-dev
mailing list
|