[squeak-dev] Inspector "Copy name"

Marcel Taeumel marcel.taeumel at hpi.de
Tue Dec 17 11:14:39 UTC 2019


Looks like that #copyName works similar to #storeOn:? There are 10 implementors of #copyName to learn from.

I would rather not remove that feature. Instead, extract it to CollectionInspector to avoid that #isKindOf: check.

Best,
Marcel
Am 16.12.2019 19:55:33 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi all,

as you might know, I'm currently refactoring the inspectors (@Chris - the idea with InspectorFieldSpec was fabulous, it improves the overall design a lot!). One short question regarding the menu action "Copy name":



As you can see in the screenshot, the current implementation has a weird edge case:

sel := ...
(self selection isKindOf: Collection)

ifTrue: [sel := '(' , sel , ' at: 1)'].
^ sel

I cannot see any sense in it. In my eyes, it's just confusing. Can I remove that edge case?

Best,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191217/79211f3e/attachment.html>


More information about the Squeak-dev mailing list