[squeak-dev] The Trunk: SUnitGUI-cmm.78.mcz
Tobias Pape
Das.Linux at gmx.de
Sat Dec 28 15:41:06 UTC 2019
> On 28.12.2019, at 15:22, Jakob Reschke <forums.jakob at resfarm.de> wrote:
>
> I concur with Christoph; -1
Same here.
-t
>
> Even if it were not possible to open the tool with a preselection, you will still assemble a test suite through manual selection. Then you may want to run a different test suite, but keep the test suite/selection in the first browser to come back later.
>
> Kind regards,
> Jakob
>
> Am Sa., 28. Dez. 2019 um 14:27 Uhr schrieb Thiede, Christoph <Christoph.Thiede at student.hpi.uni-potsdam.de>:
> -1 for that change :-)
>
>
> This commit makes it impossible to have multiple TestRunners opened side by side. For me, this is clearly a drawback. Why force unnecessary singletons?
>
> In my opinion, the old implementation was simply correct - I can open as many TestRunners as I would like to do, but if there is already an open TestRunner with the same configuration, it will be focused instead.
>
>
> > There's no way to spawn that model with any pre-selection
>
>
> How do you mean this? Try the following - before loading this commit - line by line:
>
>
> TestRunner openForSuite: StringTest suite.
> TestRunner openForSuite: CharacterTest suite.
> TestRunner openForSuite: StringTest suite.
>
>
> Best,
>
> Christoph
>
> Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
> Gesendet: Samstag, 28. Dezember 2019 05:59:42
> An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
> Betreff: [squeak-dev] The Trunk: SUnitGUI-cmm.78.mcz
>
> Chris Muller uploaded a new version of SUnitGUI to project The Trunk:
> http://source.squeak.org/trunk/SUnitGUI-cmm.78.mcz
>
> ==================== Summary ====================
>
> Name: SUnitGUI-cmm.78
> Author: cmm
> Time: 27 December 2019, 10:59:41.297401 pm
> UUID: 1c7d7b32-cdec-4875-80d8-7d2413e01a05
> Ancestors: SUnitGUI-cmm.77
>
> Fix TestRunner browser for use with Reuse Windows preference. There's no way to spawn that model with any pre-selection, it's essentially a singleton browser in Squeak.
>
> =============== Diff against SUnitGUI-cmm.77 ===============
>
> Item was changed:
> ----- Method: TestRunner>>representsSameBrowseeAs: (in category 'accessing-ui') -----
> representsSameBrowseeAs: anotherModel
> + ^ true!
> - ^ self class = anotherModel class
> - and: [ classesSelected = anotherModel classesSelected ]!
>
>
>
>
More information about the Squeak-dev
mailing list
|