[squeak-dev] The Inbox: Monticello-jr.707.mcz
Nicolas Cellier
nicolas.cellier.aka.nice at gmail.com
Sun Dec 29 18:26:36 UTC 2019
Le dim. 29 déc. 2019 à 19:07, Tobias Pape <Das.Linux at gmx.de> a écrit :
>
> > On 29.12.2019, at 18:42, commits at source.squeak.org wrote:
> >
> > A new version of Monticello was added to project The Inbox:
> > http://source.squeak.org/inbox/Monticello-jr.707.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Monticello-jr.707
> > Author: jr
>
> Isn't Jakob Trunk-commiter already? :D
>
> I don't think so.
+1
However, concerning this change, it's better to think twice.
There are a lot of senders of doSilently: and I don't think that the
intention was to not log into .changes
Are we sure that we will not loose source code of installed stuff?
> Time: 29 December 2019, 6:42:29.985327 pm
> > UUID: 5f498b54-b255-a140-bd55-c5f01b5b03ca
> > Ancestors: Monticello-ct.706
> >
> > Don't log source if system changes are suppressed.
> >
> > To be able to make some tests less noisy in the changes file.
> >
> > =============== Diff against Monticello-ct.706 ===============
> >
> > Item was changed:
> > ----- Method: MCMethodDefinition>>asMethodAddition (in category
> 'converting') -----
> > asMethodAddition
> > ^MethodAddition new
> > compile: source
> > classified: category
> > withStamp: timeStamp
> > notifying: nil
> > + logSource: SystemChangeNotifier uniqueInstance
> isBroadcasting
> > - logSource: true
> > inClass: self actualClass.!
> >
> >
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191229/16128a0a/attachment.html>
More information about the Squeak-dev
mailing list
|