[squeak-dev] Exception handling bug; NameLookupFailure>defaultAction

Jakob Reschke forums.jakob at resfarm.de
Thu Jan 3 11:03:34 UTC 2019

The following are resumable, so the resume: in defaultAction just needs to
be replaced by a return from the method:

Some of their defaultActions could rather answer their defaultResumeValue,
so it is not duplicated.

The only one remaining that needs more thinking about is NameLookupFailure.

The hint that one must/should not control the signal handling from
defaultAction could be added to Exception>defaultAction and

Am Do., 3. Jan. 2019 um 06:06 Uhr schrieb tim Rowledge <tim at rowledge.org>:

> Exception handling is fun!
> After some discussions at todays' SOB meeting, Eliot pointed out that we
> should be worrying about what the J20 standard says about exceptions.
> Interestingly, it explicitly calls out the sort of thing that
> NameLookupFailure>defaultAction does as wrong, with capital W and extra
> '!!'. So, even though I found a slightly tacky work-around that appears to
> make it function most of the time, what we actually need to do is fix the
> real problem, ie bad code in some implementations of #defaultAction. And,
> maybe, comment a few places to help future-us get it right later.
> Looking at implementations of #defaultAction in the image I see the
> following in need of fixing -
> EnvironmentRequest>>#defaultAction
> FTPConnectionException>>#defaultAction
> InMidstOfFileinNotification>>#defaultAction
> MCProxyMaterialization>>#defaultAction
> NameLookupFailure>>#defaultAction
> OutOfScopeNotification>>#defaultAction
> ProgressInitiationException>>#defaultAction
> ProgressTargetRequestNotification>>#defaultAction
> ProjectEntryNotification>>#defaultAction
> ProjectPasswordNotification>>#defaultAction
> ProjectViewOpenNotification>>#defaultAction
> RequestAlternateSyntaxSetting>>#defaultAction (note that this was related
> to an ancient syntax experiment and the involved preference is no longer
> implemented and should be finally excised - see #printAlternateSyntax)
> WebAuthRequired>>#defaultAction
> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> Strange OpCodes: START: Cancel preceding jobs in queue
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190103/a42095be/attachment.html>

More information about the Squeak-dev mailing list