[squeak-dev] StandardFileMenu should die
eliot.miranda at gmail.com
Tue Jan 8 19:15:20 UTC 2019
Hi Tim, Hi Marcel,
On Tue, Jan 8, 2019 at 10:41 AM tim Rowledge <tim at rowledge.org> wrote:
> > On 2019-01-08, at 12:01 AM, Marcel Taeumel <marcel.taeumel at hpi.de>
> > put it into the "60Deprecated" package. Please do not delete it. Also,
> add a commt to what use as substitute.
> Aww, there you go again being all reasonable :-( I just wanted to nuke it
> from orbit; is that so terrible?
> I'll be pushing to actually dump deprecated stuff more aggressively. No
> backsliding to where we have eleventy-twelve layers of deprecated stuff
> waiting to be spaced.
Here are the three uses I find in a VMMaker image. Clearly none is vital
but it would be nice to have a rewrite that doesn't use StandardFileMenu
for the B3D one. I think Marcel is right to suggest 60Deprecated as its
final resting place. Deprecated code can be unloaded in the short term and
discarded in the long. Do we have a policy on how long deprecated packages
stay in trunk?
'From Squeak5.3alpha of 2 January 2019 [latest update: #18337] on 8 January
2019 at 11:11:33 am'!
!B3DSceneExplorerMorph methodsFor: 'actions'!
| menu result newFileString myScene |
menu := StandardFileMenu oldFileMenu: (FileDirectory default) withPattern:
result := menu startUpWithCaption: 'Select 3DS model file ...'.
result ifNotNil: [
newFileString := (result directory pathName),(result directory
pathNameDelimiter asString),(result name).
myScene := (B3DScene withoutQuestionsFrom3DS: (ThreeDSParser
self scene: myScene].! !
!VMMakerTool methodsFor: 'configurations' stamp: 'ar 3/10/2002 15:05'!
| fileResult file |
fileResult := (StandardFileMenu oldFileMenu: FileDirectory default
startUpWithCaption: 'Select VMMaker configuration...'.
ifNotNil: [file := fileResult directory fullNameFor: fileResult name.
[vmMaker := VMMaker forConfigurationFile: file.
vmMaker logger: logger.
do: [self inform: 'Possible problem with path settings or platform name?'].
self updateAllViews]! !
!VMMakerTool methodsFor: 'configurations' stamp: 'rww 9/23/2001 14:17'!
"write info about the current configuration to a file."
| fileResult file |
fileResult := (StandardFileMenu newFileMenu: FileDirectory default
startUpWithCaption: 'Save VMMaker configuration...'.
fileResult ifNotNil: [
('*.config' match: fileResult name)
ifFalse: [fileResult name: (fileResult name, '.config')].
file := fileResult directory fullNameFor: fileResult name.
vmMaker saveConfigurationTo: file].
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev