[squeak-dev] The Trunk: Collections-JH.814.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Jan 25 08:15:12 UTC 2019


Marcel Taeumel uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-JH.814.mcz

==================== Summary ====================

Name: Collections-JH.814
Author: JH
Time: 24 January 2019, 10:32:33.157023 am
UUID: 2981cec1-a155-7840-bbff-827a8f3387bb
Ancestors: Collections-eem.806

Add check to FloatArray primitive fallback code to ensure that receiver and argument have the same size (argument was previously allowed to be larger than receiver, which does not make sense mathematically).

=============== Diff against Collections-eem.806 ===============

Item was changed:
  ----- Method: FloatArray>>primAddArray: (in category 'primitives-plugin') -----
  primAddArray: floatArray
  
  	<primitive: 'primitiveAddFloatArray' module: 'FloatArrayPlugin'>
+ 	self size = floatArray size ifFalse:[^self error:'Must be equal size'].
  	1 to: self size do:[:i| self at: i put: (self at: i) + (floatArray at: i)].!

Item was changed:
  ----- Method: FloatArray>>primDivArray: (in category 'primitives-plugin') -----
  primDivArray: floatArray
  
  	<primitive: 'primitiveDivFloatArray' module: 'FloatArrayPlugin'>
+ 	self size = floatArray size ifFalse:[^self error:'Must be equal size'].
  	1 to: self size do:[:i| self at: i put: (self at: i) / (floatArray at: i)].!

Item was changed:
  ----- Method: FloatArray>>primMulArray: (in category 'primitives-plugin') -----
  primMulArray: floatArray
  
  	<primitive: 'primitiveMulFloatArray' module: 'FloatArrayPlugin'>
+ 	self size = floatArray size ifFalse:[^self error:'Must be equal size'].
  	1 to: self size do:[:i| self at: i put: (self at: i) * (floatArray at: i)].!

Item was changed:
  ----- Method: FloatArray>>primSubArray: (in category 'primitives-plugin') -----
  primSubArray: floatArray
  
  	<primitive: 'primitiveSubFloatArray' module: 'FloatArrayPlugin'>
+ 	self size = floatArray size ifFalse:[^self error:'Must be equal size'].
  	1 to: self size do:[:i| self at: i put: (self at: i) - (floatArray at: i)].!



More information about the Squeak-dev mailing list