[squeak-dev] Tests | #testMaxLiteralsWithClassReferenceInClosure works for SistaV1 bytecode set but not V3PlusClosures

Eliot Miranda eliot.miranda at gmail.com
Thu Jul 4 22:32:40 UTC 2019


Hi Marcel,


> On Jul 4, 2019, at 5:04 AM, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:
> 
> Hi all!
> 
> The test CompilerTest >> #testMaxLiteralsWithClassReferenceInClosure fails for V3PlusClosures. It is off by 5 literals.
> 
> Could it be because V3PlusClosures inlines blocks in the same compiled method but SistaV1 extracts them into an extra compiled block?

Almost certainly.  Use the explore view to verify.

> 
> I was wondering whether that "[ DateAndTime now. Date today. Time ]." accounts for 5 literals ... even though I am only seeing 4. :-)

It should indeed be 5.  Weird :-)

> 
> Any thoughts?
> 
> Best,
> Marcel
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190704/88af66df/attachment.html>


More information about the Squeak-dev mailing list