[squeak-dev] The Inbox: Chronology-Core-cbc.45.mcz

Chris Cunningham cunningham.cb at gmail.com
Wed May 15 02:47:20 UTC 2019


On Tue, May 14, 2019 at 6:52 PM Chris Muller <asqueaker at gmail.com> wrote:

> Chris, I'm sure its fine but still interested in taking a look but
> can't get to it tonight.
>
Ok, will wait.

>
> On Tue, May 14, 2019 at 7:32 PM David T. Lewis <lewis at mail.msen.com>
> wrote:
> >
> > +1
> >
> > The original code answered a new instance if and only if the offset
> > of aDateAndTime was different from DateAndTime class>>localOffset,
> > whatever that might happen to be. The method name #asLocal implies
> > that it should (consistently) answer a new instance. That sounds
> > more correct to me, so as long as the tests still pass and nothing
> > else is broken, please move it to trunk.
> >
> > Dave
> >
>
The test still pass.
And the only senders of this method in the base image is the tests testing
it.

Thanks,
cbc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190514/3e371777/attachment.html>


More information about the Squeak-dev mailing list