[squeak-dev] The Inbox: Tools-jr.895.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Mon Sep 23 09:30:01 UTC 2019


Hmm... is there a bug in the RecentMessages' "cache invalidation" protocol? I would expect that RecentMessages listens to all code changes and updates its list of recent messages accordingly.

There might be other symptoms lurking in the image. Would it be easy to fix the updates in RecentMessages instead?

Best,
Marcel
Am 22.09.2019 21:50:57 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-jr.895.mcz

==================== Summary ====================

Name: Tools-jr.895
Author: jr
Time: 22 September 2019, 9:50:46.28851 pm
UUID: 58fc8b0a-c340-8f49-9ef7-7a93d9ddbc2a
Ancestors: Tools-jr.894

Fix "does not understand" edge case with formatted labels in RecentMessages

=============== Diff against Tools-jr.894 ===============

Item was changed:
----- Method: CodeHolder>>formattedLabel:forSelector:inClass: (in category 'message list') -----
formattedLabel: aString forSelector: aSymbol inClass: aClass
"Show deprecated messages differently so that users recognize them quickly to avoid them."

| formattedLabel |
+ aClass ifNil:
+ [^ aString asText
+ "Outdated MethodReference.
+ Appears in RecentMessages after class renames, for example."].
(aSymbol = #Definition or: [aSymbol = #Comment])
ifTrue: [aClass isDeprecated
ifFalse: [^ aString]]
ifFalse: [(aClass isDeprecated or: [(aClass compiledMethodAt: aSymbol ifAbsent: [^ aString]) isDeprecated])
ifFalse: [^ aString]].

formattedLabel := aString asText.

(self userInterfaceTheme deprecatedMessageAttributes ifNil: [{TextColor gray. TextEmphasis struckOut}]) do: [:textAttribute |
formattedLabel addAttribute: textAttribute].

^ formattedLabel.!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190923/0d5be564/attachment.html>


More information about the Squeak-dev mailing list