[squeak-dev] The Inbox: CollectionsTests-ct.321.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Fri Sep 27 14:28:36 UTC 2019


I think you find a bug regarding the recent change in HashedCollection class >> #goodPrimes. Yet, what does this test do? A comment would be nice. :-) Same for Collections-ct.857 regarding that "array+1".

Best,
Marcel
Am 27.09.2019 16:15:30 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of CollectionsTests was added to project The Inbox:
http://source.squeak.org/inbox/CollectionsTests-ct.321.mcz

==================== Summary ====================

Name: CollectionsTests-ct.321
Author: ct
Time: 27 September 2019, 4:15:21.022642 pm
UUID: 6638fd69-d57a-7e43-a99c-2d99b52a0b36
Ancestors: CollectionsTests-jr.320

Extend OrderedDictionaryTest >> #testCopyFromTo to reveal a bug

=============== Diff against CollectionsTests-jr.320 ===============

Item was changed:
----- Method: OrderedDictionaryTest>>testCopyFromTo (in category 'tests - copying') -----
testCopyFromTo

+ | copy |
1 to: 10 do: [:index |
sut at: index put: nil].

+ copy := sut copyFrom: 3 to: 5.
+ self assert: (3 to: 5) asArray equals: copy keys.
+ copy at: 3 put: #foo.
+ self assert: (sut at: 3) isNil.
+
+ copy at: 11 put: #ba.
+ self assert: #ba equals: (copy at: 11).!
- (sut copyFrom: 3 to: 5) in: [:copy |
- self assert: (3 to: 5) asArray equals: copy keys.
- copy at: 3 put: #foo.
- self assert: (sut at: 3) isNil.].!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190927/27f6fbd9/attachment.html>


More information about the Squeak-dev mailing list