Another thought: Since the older meaning of TextMorph >> #contents: was to reset the wrapFlag to "false" we might want to fix all those cases:

TextMorph new contents: 'foobar'.

So, yes, we maybe want to initialize the wrapFlag with "false"...

Best,
Marcel
Am 30.09.2019 13:33:40 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
... TextMorph >> #fit works as expected in this case. :-)

Best,
Marcel
Am 30.09.2019 13:30:04 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
> Is this really what we want?

Maybe, maybe not. We cannot know without context information. :-) I suppose it should be "false" by default. In the MenuMorph, however, I would assume that the filter text was not initialized correctly.

Best,
Marcel
Am 30.09.2019 12:42:57 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi all,

can you reproduce the following?



I assume it this bug was revealed (not caused) by Morphic-mt.1520, so by default, each TextMorph now has the wrapFlag true. Is this really what we want?


Minimal example to reproduce:
m := Morph new.
m openInHand.
m extent: 300 @ 200.
m cellPositioning: #center.
m changeTableLayout.
t := TextMorph new
contents: 'Hello world';
yourself.
t autoFit: true.
t container
Works before, does not work after the recent commit.

Should we maybe initialize wrapFlag with false, in order to revert the behavior from before Morphic-mt.1520? I know also other implementations, aside from Trunk, which are failing after the update.

Best,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190930/12a8d9dd/attachment-0001.html>