Hi Subbu!

+1

Those arbitrary number of retries did never work for me in Metacello either. There should some delay in between. The one you proposed here sounds good. And we have a virtually unlimited number of retries here. :-)

Best,
Marcel
Am 02.04.2020 17:29:55 schrieb K K Subbu <kksubbu.ml at gmail.com>:
Hi,

I have an alternate proposal to recover from 500 error on HTML help
topics. Instead of retrying 3 times [1], we just back off and retry only
when the document is needed next. If the server is busy then backing off
may be better than retries.

If a 'refresh' menu is available to force an update, then this changeset
is not needed.

[1]
http://forum.world.st/The-Inbox-HelpSystem-Core-ct-131-mcz-td5112713.html

Regards .. Subbu

On 02/04/20 3:15 PM, commits at source.squeak.org wrote:
> A new version of HelpSystem-Core was added to project The Inbox:
> http://source.squeak.org/inbox/HelpSystem-Core-kks.120.mcz
>
> ==================== Summary ====================
>
> Name: HelpSystem-Core-kks.120
> Author: kks
> Time: 2 April 2020, 8:45:13.607196 pm
> UUID: 33119c75-ba40-45d4-8ede-7086b7f4bc60
> Ancestors: HelpSystem-Core-mt.119
>
> Fetch a topic document afresh from the server if the previous fetch resulted in an 500 error.
>
> =============== Diff against HelpSystem-Core-mt.119 ===============
>
> Item was changed:
> ----- Method: HtmlHelpTopic>>document (in category 'accessing') -----
> document
>
> + (document isNil or: [document includesSubstring: '500 Internal']) ifTrue: [
> + document := [
> + (HTTPSocket httpGet: self url accept: 'text/html') contents
> + ] on: Error do: [:err | err printString]].
> + ^document!
> - ^ document ifNil: [document :=
> - [
> - (HTTPSocket httpGet: self url accept: 'text/html') contents
> - ] on: Error do: [:err | err printString]]!
>
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200403/8a61cd5a/attachment.html>