Hi Christoph.

> Afaik #browseAllCallsOn: already goes through the model, at least in MessageTraces?

MessageTraces *is* the model. I was talking about TextEditor, which is shared among those CoderHolder/StringHolder tools.

Best,
Marcel
Am 26.04.2020 18:02:31 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,

> Maybe #browseIt and #sendersOfIt should also go through the model?

Afaik #browseAllCallsOn: already goes through the model, at least in MessageTraces? Sounds like a good idea for #browseClass:, too :-)

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Sonntag, 26. April 2020 16:30:38
An: Robert via Squeak-dev; packages at lists.squeakfoundation.org
Betreff: Re: [squeak-dev] The Trunk: Morphic-mt.1649.mcz
 
Hi Christoph.

> What was the reason for sending it to the system navigation directly? :-)

No reason, just oversight ... and maybe evidence of a surprising, inconsistent extension point. Maybe #browseIt and #sendersOfIt should also go through the model? Well, #doIt and #printIt do already go through the model if that model reponds to certain messages.

Best,
Marcel
Am 24.04.2020 19:59:20 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,

apparently, this change broke the #traceMessage preference since #browseAllImplementorsOf: is not dispatched to the MessageTrace any longer. What was the reason for sending it to the system navigation directly? :-)

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Mittwoch, 22. April 2020 10:46:19
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-mt.1649.mcz
 
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1649.mcz [http://source.squeak.org/trunk/Morphic-mt.1649.mcz]

==================== Summary ====================

Name: Morphic-mt.1649
Author: mt
Time: 22 April 2020, 10:46:13.027214 am
UUID: 6b61e640-ba14-0d47-80af-c926334d4b82
Ancestors: Morphic-mt.1648

Fixes small glitch in text editor's #implementorsOfIt to behave like #sendersOfIt.

=============== Diff against Morphic-mt.1648 ===============

Item was changed:
  ----- Method: TextEditor>>implementorsOfIt (in category 'menu messages') -----
  implementorsOfIt
         "Open an implementors browser on the selected selector"
+
-        | aSelector |
         self lineSelectAndEmptyCheck: [^ self].
+        self selectedSelector ifNotNil:
+                [:aSelector| ^self systemNavigation browseAllImplementorsOf: aSelector].
+        self selectedLiteral ifNotNil:
+                [:aLiteral| ^self systemNavigation browseAllImplementorsOf: aLiteral].
+        morph flash.!
-        (aSelector := self selectedSelector) == nil ifTrue: [^ morph flash].
-        model browseAllImplementorsOf: aSelector!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200426/c5be0055/attachment-0001.html>