[squeak-dev] The Trunk: Morphic-mt.1652.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Apr 27 07:32:04 UTC 2020


Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1652.mcz

==================== Summary ====================

Name: Morphic-mt.1652
Author: mt
Time: 27 April 2020, 9:31:57.493264 am
UUID: d23bbde5-4e42-3547-960d-39994fc21f56
Ancestors: Morphic-ct.1651

Fixes regression #browseIt in TraceMessages, too. Now all recent hick-ups with TraceMessages are gone. There are still some hooks missing such as #browseAllAccessTo:from:.

However, I think we should push down those backstops from Object to Model.

Note that I already backported this fix to Squeak 5.3.

=============== Diff against Morphic-ct.1651 ===============

Item was changed:
  ----- Method: TextEditor>>browseIt (in category 'menu messages') -----
  browseIt
  	"Launch a browser for the current selection, if appropriate."
  
  	Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt].
  
  	self lineSelectAndEmptyCheck: [^ morph flash].
  
  	"First, try to show all accesses to instance or class variables."
  	self selectedInstanceVariable ifNotNil:
  		[:nameToClass | self systemNavigation
  			browseAllAccessesTo: nameToClass key
  			from: nameToClass value].
  	self selectedClassVariable ifNotNil:
+ 		[:binding | self model browseAllCallsOn: binding].
- 		[:binding | self systemNavigation browseAllCallsOn: binding].
  
  	"Then, either browse the class (from a binding) or all implementors of a selector."
  	self selectedBinding ifNotNil:
  		[:binding | ^ self systemNavigation browseClass: binding].
  	self selectedSelector ifNotNil:
+ 		[:selector | ^ self model browseAllImplementorsOf: selector].
- 		[:selector | ^ self systemNavigation browseAllImplementorsOf: selector].
  	
  	morph flash!



More information about the Squeak-dev mailing list