[squeak-dev] The Inbox: Tools-ct.944.mcz

Levente Uzonyi leves at caesar.elte.hu
Sun Feb 23 18:40:47 UTC 2020


How about not adding #browseVersionsOf:, but chaging the 
body of #browseMethod: to what #browseVersionsOf: is below?

^x ifNil: [ ^nil ] is the same as ^x but longer, isn't it?


Levente

On Sun, 23 Feb 2020, commits at source.squeak.org wrote:

> Christoph Thiede uploaded a new version of Tools to project The Inbox:
> http://source.squeak.org/inbox/Tools-ct.944.mcz
>
> ==================== Summary ====================
>
> Name: Tools-ct.944
> Author: ct
> Time: 23 February 2020, 5:50:43.489831 pm
> UUID: 0c54eef3-3e82-1340-9426-3e94151157d6
> Ancestors: Tools-mt.940
>
> Fixes a bug/unnecessary limitation in VersionsBrowser class >> #browseMethod: that raised an error when browsing a method that had been removed from the system.
>
> You can also reproduce it via: thisContext method browse "on a fresh image".
>
> =============== Diff against Tools-mt.940 ===============
>
> Item was changed:
>  ----- Method: VersionsBrowser class>>browseMethod: (in category 'instance creation') -----
>  browseMethod: aCompiledMethod
> 
> + 	^ (self browseVersionsOf: aCompiledMethod)
> + 		ifNil: [^ nil];
> - 	^ (self browseVersionsForClass: aCompiledMethod methodClass selector: aCompiledMethod selector)
>  		selectMethod: aCompiledMethod;
>  		yourself!
>
> Item was added:
> + ----- Method: VersionsBrowser class>>browseVersionsOf: (in category 'instance creation') -----
> + browseVersionsOf: aCompiledMethod
> + 
> + 	| methodClass methodSelector |
> + 	methodClass := aCompiledMethod methodClass.
> + 	methodSelector := aCompiledMethod selector.
> + 	^ self
> + 		browseVersionsOf: aCompiledMethod
> + 		class: methodClass
> + 		meta: methodClass isMeta
> + 		category: (methodClass organization categoryOfElement: methodSelector)
> + 		selector: methodSelector!


More information about the Squeak-dev mailing list