On Thu, Jan 2, 2020 at 2:19 PM Thiede, Christoph <
Christoph.Thiede at student.hpi.uni-potsdam.de> wrote:

> Hi Chris,
>
>
> nice issue! I agree this would be an improvement in debugging scenarios.
>
>
> However, when I press Shift + ArrowRight to extend the selection, I would
> indeed expect that the cursor is scrolled into view.
>
Ah ha, THAT's why Marcel had that second call to #scrollToShow:
in PluggableTextMorph>>#scrollSelectionIntoView:...   Nice catch!  I've
just posted a fixed version, Morphic-cmm.1615.

> I think we would need to distinguish between "machinal selection" and
> "selection by user."
>
Good idea!

> And shouldn't we respect the selection orientation here (i.e., which of
> markIndex and pointIndex is larger - see TextEditor >> #exchange)?
>
I think so, but I'm not seeing where this is violated..  A little help
please?   :)


>
> But I would rather dislike a preference, imho we should make it dependent
> on the origin of the selection (machine vs. user) to achieve the best
> convenience.
>

Agree.

Thanks for the review,
  Chris


>
> Best,
> Christoph
> ------------------------------
> *Von:* Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im
> Auftrag von Chris Muller <asqueaker at gmail.com>
> *Gesendet:* Donnerstag, 2. Januar 2020 03:30:48
> *An:* squeak dev
> *Betreff:* [squeak-dev] stepping in small panes
>
> Hi all,
>
> When debugging on a small screen and a larger font, block expressions can
> easily overrun the size of the text pane.  Currently when stepping,
> selecting a stack frame, clicking Where -- anything that changes the text
> selection, it positions you to the bottom.
>
> [image: show-bottom-sel.png]
>
> Unfortunately, this makes debugging cumbersome, because I need to see the
> beginning of the selection instead of the end, to know what I'm stepping
> through.
>
> [image: show-top-sel.png]
>
> I use soft wrap, so don't face any issue along the horizontal dimension,
> but for the same principle, Morphic-cmm.1614 treats it similarly.
>
> Before:
> [image: show-right-sel.png]     VS
> [image: show-left-sel.png]
>
> What do you think?  Preference-worthy?
>
> Best,
>   Chris
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200102/bee28c7b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: show-bottom-sel.png
Type: image/png
Size: 46859 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200102/bee28c7b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: show-top-sel.png
Type: image/png
Size: 47916 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200102/bee28c7b/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: show-right-sel.png
Type: image/png
Size: 22489 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200102/bee28c7b/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: show-left-sel.png
Type: image/png
Size: 31991 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200102/bee28c7b/attachment-0007.png>