[squeak-dev] The Trunk: Morphic-mt.1612.mcz
Marcel Taeumel
marcel.taeumel at hpi.de
Mon Jan 6 13:55:20 UTC 2020
Having so many changes in this place, I chose to not add the post-load script because that means to add an entry in the update map to ensure that script will be evaluated when updating older images.
Best,
Marcel
Am 28.12.2019 16:06:04 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,
I see. But wouldn't this be the responsibility of a postload script (EventSensor installKeyDecodeTable)? We don't want to break any image by deploying an update, do we? :)
---
By the way, there is still another behavior regarding to Ctrl/Cmd which I don't like:
On Windows, Ctrl + Home behaves like Cmd + A and Ctrl + End behaves like Cmd + Shift + D.
Personally, I would prefer them to do exactly the same as Cmd + Home and Cmd + End instead.
In that respect, the editor does not seem to respect the duplication preferences.
Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Dienstag, 24. Dezember 2019 11:28:06
An: John Pfersich via Squeak-dev; packages at lists.squeakfoundation.org
Betreff: Re: [squeak-dev] The Trunk: Morphic-mt.1612.mcz
You have to update the mapping table. Try enable/disable the preference again.
Best,
Marcel
Am 23.12.2019 18:09:57 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,
I am running two Trunk images parallel. After installing the latest updates (19284 -> 19288), one of them stopped responding to Ctrl + 0 (zero) to focus the address bar, or Ctrl + [a digit] to open the corresponding docking bar menu. However, in the other image, this still works!
Preferences:
If I turn the selected preference off and on again, everything works fine.
Does one of the latest commits require some reset? If yes, should this be automated via a postload script again? :)
Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Montag, 23. Dezember 2019 11:28:29
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-mt.1612.mcz
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1612.mcz [http://source.squeak.org/trunk/Morphic-mt.1612.mcz]
==================== Summary ====================
Name: Morphic-mt.1612
Author: mt
Time: 23 December 2019, 11:28:22.440349 am
UUID: e9dac727-05f5-6d4a-9559-98564f39afe6
Ancestors: Morphic-mt.1611
Fixes issue with CTRL+CMD (key down) combinations and unexpectedly selecting the "Tools" menu on some platforms due to low-level key codes in such key-down events.
Complements Kernel-mt.1290.
=============== Diff against Morphic-mt.1611 ===============
Item was changed:
----- Method: DockingBarMorph>>filterEvent:for: (in category 'events-processing') -----
filterEvent: aKeyboardEvent for: anObject
"Provide keyboard shortcuts."
| index itemToSelect |
aKeyboardEvent controlKeyPressed
ifFalse: [^ aKeyboardEvent].
+ aKeyboardEvent isKeystroke
- (aKeyboardEvent isKeyDown or: [aKeyboardEvent isKeystroke]) "We also need #keyDown for Windows platforms because CTRL+X does not trigger key strokes there..."
ifFalse: [^ aKeyboardEvent].
"Search field."
aKeyboardEvent keyCharacter = $0
ifTrue: [
self searchBarMorph ifNotNil: [ :morph |
morph model activate: aKeyboardEvent in: morph ].
^ aKeyboardEvent ignore "hit!!"].
"Select menu items."
(aKeyboardEvent keyValue
between: $1 asciiValue
and: $9 asciiValue)
ifFalse: [^ aKeyboardEvent].
index := aKeyboardEvent keyValue - $1 asciiValue + 1.
itemToSelect := (self submorphs select: [ :each |
each isKindOf: DockingBarItemMorph ])
at: index
ifAbsent: [^ aKeyboardEvent].
self activate: aKeyboardEvent.
self
selectItem: itemToSelect
event: aKeyboardEvent.
^ aKeyboardEvent ignore "hit!!"!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200106/1a465831/attachment-0001.html>
More information about the Squeak-dev
mailing list
|