A problem with this implementation (both old and new) is that it appears to rely on the fact that no other packages are installed - which is true when creating a release from a fresh image, but wrong for many existing images. I don't know enough about the ReleaseBuilder: This code is only expected to be run on a CI server, is it? I won't be able to build the release locally without adding Trunk & Co. to all installed third-party packages? Do you think this would be worth a change?


allTrunkPackages

| trunk |
trunk := MCRepository trunk.
^ MCWorkingCopy allManagers
collect: [:copy | copy repositoryGroup]
thenSelect: [:group | group repositories includes: trunk]


What would be the best approach for me to test this commit?


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Donnerstag, 9. Januar 2020 08:42:10
An: squeak-dev at lists.squeakfoundation.org
Betreff: [squeak-dev] The Inbox: ReleaseBuilder-ct.205.mcz

Christoph Thiede uploaded a new version of ReleaseBuilder to project The Inbox:
http://source.squeak.org/inbox/ReleaseBuilder-ct.205.mcz

==================== Summary ====================

Name: ReleaseBuilder-ct.205
Author: ct
Time: 9 January 2020, 8:41:48.233248 am
UUID: 8951750a-cd22-6843-b5e1-20b0aa5b6e20
Ancestors: ReleaseBuilder-mt.204

Add The Inbox to all packages by default

=============== Diff against ReleaseBuilder-mt.204 ===============

Item was changed:
  ----- Method: ReleaseBuilder class>>addAdditionalRepositories (in category 'scripts - support') -----
  addAdditionalRepositories

+        self addGlobalRepository: self inboxRepository.
-        MCRepositoryGroup default addRepository: self inboxRepository.

         #(
                 'http://www.squeaksource.com/MetacelloRepository'
                 'http://www.hpi.uni-potsdam.de/hirschfeld/squeaksource/MetacelloRepository'
                         ) collect: [:url |
                                 MCRepositoryGroup default addRepository: (MCHttpRepository
                                         location: url
                                         user: 'squeak'
                                         password: 'squeak')].!

Item was added:
+ ----- Method: ReleaseBuilder class>>addGlobalRepository: (in category 'scripts - support') -----
+ addGlobalRepository: anMCRepository
+
+        MCRepositoryGroup default addRepository: anMCRepository.
+        MCWorkingCopy allManagers
+                do: [ :each | each repositoryGroup:
+                        (MCRepositoryGroup new
+                                 addRepository: anMCRepository ;
+                                 yourself) ].!

Item was changed:
  ----- Method: ReleaseBuilder class>>switchToNewRepository: (in category 'scripts - support') -----
+ switchToNewRepository: anMCRepository
+
- switchToNewRepository: anMCRepository
         MCMcmUpdater defaultUpdateURL: anMCRepository description.
         MCRepositoryGroup reset.
+        self addGlobalRepository: anMCRepository.!
-        MCRepositoryGroup default addRepository: anMCRepository.
-        MCWorkingCopy allManagers do:
-                [ : each | each repositoryGroup:
-                        (MCRepositoryGroup new
-                                 addRepository: anMCRepository ;
-                                 yourself) ]!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200109/bd13ff5e/attachment.html>