[squeak-dev] AllocationTest>>#testOutOfMemorySignal fails on 32bit system
David T. Lewis
lewis at mail.msen.com
Fri Jul 3 22:57:56 UTC 2020
On Fri, Jul 03, 2020 at 11:17:52AM -0700, Eliot Miranda wrote:
> > On Jul 2, 2020, at 6:32 PM, David T. Lewis <lewis at mail.msen.com> wrote:
> > ???On Thu, Jul 02, 2020 at 04:35:03PM -0700, tim Rowledge wrote:
> >> On a Raspberry Pi OS 32bit this test fails because of an oversight - the parameter passed to vmParameterAt:put: cannot exceed SmallInteger maxVal. It makes the careful testing for 32/64bit image seem a bit silly.
> >> This means we can only ask for up to ~1GB space for free space on a 32bit image system and so I propose to clamp the requested value in AllocationTest>>#setFreeSpaceLimitOf:around: There don't appear to be any other places right now that need attention.
> >> If I don't hear any outraged screams soon I'll just commit it to trunk.
> > So rather than
> > 1024 * 1024 * 1024
> > it should instead be
> > 16r3FFFFFFF
> > so that is it less than or equal to SmallInteger maxVal for either 32 or
> > 64 bit images. Is that the change?
> > No outraged screams from me.
> Nor from me, but one weak bleat for it to read
> (1024 * 1024 * 1024 min: SmallInteger maxVal)
Weakly bleating in the affermative (the intent is much clearer when written this way).
More information about the Squeak-dev