[squeak-dev] [BUG] in Debugger >> #newStack: optimization

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Mon Mar 2 13:48:05 UTC 2020


Steps to reproduce:

  1.  Debug it:
[^ #foo] ensure: [#bar]
  2.  Press Through two times to get into [#bar].

Expected behavior:

The stack list should look like this:
[cid:365dffbc-651c-472c-91de-2779499a9dfe]

Actual behavior:
Actually, it looks like this:
[cid:e754f61d-f4bd-4af9-b90b-22c2d2deffa0]
Selecting the second top context reveals that the list contents are wrong:
[cid:def1c577-b17d-44e6-83b7-110622436635]

Considerations:
The failure appears to happen in Debugger >> #newStack:, where the assumption is made that if the new stack is higher by exactly one context compared to the old one (diff = 1), then only the top context could have changed. The example shows that this assumption is wrong.
A fix for this particular issue is on the way into the inbox. However, I'm not sure whether it will be an adequate solution but not only an ugly workaround.

Is this optimization relevant at all today? I found an older screenshot (in Squeak by Example) that looks as if some previous versions of Squeak may have decompiled all blocks for the #printString representation:
[cid:9b23ddcb-fd0b-4bb8-a07e-574897e57ecb]

Looking forward to your feedback! :-)

Best,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200302/3bec03d2/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 25591 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200302/3bec03d2/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 26699 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200302/3bec03d2/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 25614 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200302/3bec03d2/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 144591 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200302/3bec03d2/attachment-0007.png>


More information about the Squeak-dev mailing list