[squeak-dev] The Trunk: Compiler-ct.426.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Mon Mar 30 10:28:05 UTC 2020


Hi Marcel,
due to hackish nature of this piece of code, it's going to be difficult to
find an enlightening comment.
Eliot rather suggested a rewrite of this portion.

Le lun. 30 mars 2020 à 12:17, Marcel Taeumel <marcel.taeumel at hpi.de> a
écrit :

> Hi all.
>
> Changing a "0" into a "nil" deserves a comment *in* that changed method.
> Otherwise, this is meant to be changed back in the future because "0" maybe
> be more readable than "nil". :-)
>
> Best,
> Marcel
>
> Am 28.03.2020 14:32:28 schrieb commits at source.squeak.org <
> commits at source.squeak.org>:
> Nicolas Cellier uploaded a new version of Compiler to project The Trunk:
> http://source.squeak.org/trunk/Compiler-ct.426.mcz
>
> ==================== Summary ====================
>
> Name: Compiler-ct.426
> Author: ct
> Time: 28 March 2020, 1:22:49.51256 am
> UUID: 761924e9-77a0-1144-9533-8a7c22c03332
> Ancestors: Compiler-ct.424
>
> Fixes a bug regarding decompilation of special selectors.
>
> The following did not work before:
>
> (OrderedCollection >> #asArray) decompile generate valueWithReceiver: {42}
> asOrderedCollection arguments: #(). "MessageNotUnderstood:
> OrderedCollection>>#Array=>Array"
>
> See also this thread:
> http://forum.world.st/The-Inbox-EToys-ct-367-mcz-tp5105507p5114020.html
>
> =============== Diff against Compiler-ct.424 ===============
>
> Item was changed:
> ----- Method: DecompilerConstructor>>codeAnySelector: (in category
> 'constructor') -----
> codeAnySelector: selector
>
> ^SelectorNode new
> key: selector
> + index: nil
> - index: 0
> type: SendType!
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200330/24db4723/attachment.html>


More information about the Squeak-dev mailing list