[squeak-dev] The Trunk: WebClient-Core-tobe.120.mcz

commits at source.squeak.org commits at source.squeak.org
Fri May 8 06:56:32 UTC 2020


Marcel Taeumel uploaded a new version of WebClient-Core to project The Trunk:
http://source.squeak.org/trunk/WebClient-Core-tobe.120.mcz

==================== Summary ====================

Name: WebClient-Core-tobe.120
Author: tobe
Time: 7 May 2020, 8:03:26.842149 pm
UUID: e511b96d-6164-458e-bebd-4bb4f42cfb72
Ancestors: WebClient-Core-nice.119

If we get a 304, do not try to parse content

In particular, since content-length is typically not set for a 304 response (https://tools.ietf.org/html/rfc7230#section-3.3.2) and we somehow failed to notice the connection being closed, we ended up with a timeout instead. This caused some Metacello tests to time out.

=============== Diff against WebClient-Core-nice.119 ===============

Item was changed:
  ----- Method: WebResponse>>getContent (in category 'private') -----
  getContent
  	"Do not read any content if this was a HEAD request or code is 204 (no content)"
+ 	(request method = 'HEAD' or: [code = 204 or: [code = 304]]) ifTrue:[^''].
- 	(request method = 'HEAD' or: [code = 204]) ifTrue:[^''].
  	^super getContent!



More information about the Squeak-dev mailing list