[squeak-dev] HtmlHelpTopic with pictures was: Re: The Trunk: MonticelloConfigurations-mt.160.mcz

karl ramberg karlramberg at gmail.com
Mon May 11 11:16:19 UTC 2020


Hi.
Your charge set is good. I didnt know about the dynamic variable.


Best,
Karl

On Mon, 11 May 2020 at 10:01, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:

> Hi Karl!
>
> Nice! What do you think of using a dynamic variable instead of adding
> #asTextFromHtmlWithBaseURI: to String? Find attached a changeset.
>
> Best,
> Marcel
>
> Am 10.05.2020 10:26:11 schrieb karl ramberg <karlramberg at gmail.com>:
> Here is a hacked version of HtmlHelpTopic that download pictures from the
> Swiki.
>
> Best,
> Karl
>
>
> On Sat, May 9, 2020 at 3:00 PM karl ramberg <karlramberg at gmail.com> wrote:
>
>> Hi,
>> I was thinking that HTMLHelpTopic would download forms as well now, so we
>> would see pictures from the Swiki for example :-).
>> But it seems HtmlReadWriter does not handle relative URL, it only works
>> with the full URL.
>> Most pictures in the Swiki are relative:
>>
>> <img width=1 height=6 src="/schemes/squeak/topborder.gif">
>>
>> Do you have any suggestions on how to fix this ?
>>
>> Best,
>> Karl
>>
>>
>> On Mon, Apr 27, 2020 at 10:37 AM Marcel Taeumel <marcel.taeumel at hpi.de>
>> wrote:
>>
>>> Hi Tom,
>>>
>>> thanks for the explanation! :-) This is the current dialog in hi-dpi
>>> mode:
>>>
>>>
>>>
>>> Best,
>>> Marcel
>>>
>>> Am 27.04.2020 09:35:15 schrieb Beckmann, Tom <
>>> tom.beckmann at student.hpi.uni-potsdam.de>:
>>> Hi Christoph, hi Marcel,
>>>
>>> looking at the picture, it appears to have a height of 20 pixels, which
>>> is just above what is commonly used as the default body text size in the
>>> Web (and for example in a GitHub README) of 16px. In the web, travis will
>>> by default suggest linking to an SVG file that has a viewport height of
>>> 20px at the default resolution. For 2x HiDPI, this would then get doubled
>>> to be 40 rendered pixels high. If you were to place a PNG file with a
>>> height of 20px in your website, it would just get scaled up and appear
>>> blurry next to the crisp text, which is why rasterized icons are often
>>> provided at multiple resolutions[1].
>>>
>>> So in this case, I would argue that simply scaling by whatever scale
>>> factor the RealEstateAgent suggests is the "correct" behavior. What exactly
>>> the rules concerning alignment of the image in the text are in the web, I
>>> would also have to look up. I would imagine they do quite a bit of trickery
>>> to get baselines to match prettily.
>>>
>>> Best,
>>> Tom
>>>
>>> [1]
>>> https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images
>>> ________________________________________
>>> From: Squeak-dev on behalf of Taeumel, Marcel
>>> Sent: Monday, April 27, 2020 8:50:27 AM
>>> To: Robert via Squeak-dev
>>> Subject: Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz
>>>
>>> Hi Christoph,
>>>
>>> I wonder what the conventions in the Web-programming world are in this
>>> regard. Using Firefox, the PNG from TravisCI happens to be "just of the
>>> right size" on a low-dpi display. After zooming in, that picture gets
>>> blurry. I wouldn't bother 1-2 pixels off for the sake of not being blurry.
>>> Or maybe our text anchors need some option to be on the baseline but not
>>> considered when computing the line height?
>>>
>>> Best,
>>> Marcel
>>>
>>> Am 26.04.2020 20:21:10 schrieb Thiede, Christoph :
>>>
>>> Hi Marcel,
>>>
>>>
>>> > While we cannot call #scaledToHeight: depending on the text's current
>>> font properties,
>>>
>>>
>>> Why not? Is there any HTML style attribute we could use for this
>>> purpose, or would this be a too major change?
>>>
>>>
>>> Best,
>>>
>>> Christoph
>>>
>>>
>>> ________________________________
>>> Von: Squeak-dev im Auftrag von Taeumel, Marcel
>>> Gesendet: Montag, 20. April 2020 10:06:45
>>> An: gettimothy via Squeak-dev
>>> Betreff: Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz
>>>
>>> > > 1. Can we automatically use #scaledToHeight: for the badge to avoid
>>> the inconsistent row heights?
>>> > Oh, definitely. I forgot to call #scaleIconToDisplay ...
>>>
>>> Sorry, I mixed that up. While we cannot call #scaledToHeight: depending
>>> on the text's current font properties, we should call #scaledToSize: and
>>> honor RealEstateAgent >> scaleFactor. It is the best we have at the moment.
>>> --- #scaleIconToDisplay would also not work because that scales down bigger
>>> images, which we do not want in HTML content.
>>>
>>> Best,
>>> Marcel
>>>
>>> Am 20.04.2020 08:49:49 schrieb Marcel Taeumel :
>>>
>>> > 1. Can we automatically use #scaledToHeight: for the badge to avoid
>>> the inconsistent row heights?
>>>
>>>
>>> Oh, definitely. I forgot to call #scaleIconToDisplay. I would rather not
>>> make a assumptions about the surrounding text but maybe add support
>>> width/height to the tag.
>>>
>>>
>>> > 2. TextURL and TextReference seem not to work well together: In my
>>> image, only the left half of the banner is actually clickable.
>>>
>>>
>>> You can open a new discussion for that. :-) And maybe isolate the issue
>>> first in a compact example for everybody to try out.
>>>
>>>
>>> Best,
>>>
>>> Marcel
>>>
>>> Am 18.04.2020 15:36:05 schrieb Thiede, Christoph :
>>>
>>> I love this idea! :D
>>>
>>>
>>> Two comments:
>>>
>>>
>>> 1. Can we automatically use #scaledToHeight: for the badge to avoid the
>>> inconsistent row heights?
>>>
>>> 2. TextURL and TextReference seem not to work well together: In my
>>> image, only the left half of the banner is actually clickable.
>>>
>>>
>>> Best,
>>>
>>> Christoph
>>>
>>> ________________________________
>>> Von: Squeak-dev im Auftrag von David T. Lewis
>>> Gesendet: Freitag, 17. April 2020 20:49 Uhr
>>> An: The general-purpose Squeak developers list
>>> Betreff: Re: [squeak-dev] The Trunk: MonticelloConfigurations-mt.160.mcz
>>>
>>> That's brilliant :-)
>>>
>>> Dave
>>>
>>> On Fri, Apr 17, 2020 at 07:04:17PM +0200, karl ramberg wrote:
>>> > Cool
>>> >
>>> > Best,
>>> > Karl
>>> >
>>> > On Fri, Apr 17, 2020 at 5:25 PM Marcel Taeumel
>>> > wrote:
>>> >
>>> > >
>>> > > Am 17.04.2020 17:17:37 schrieb commits at source.squeak.org
>>> > > commits at source.squeak.org>:
>>> > > Marcel Taeumel uploaded a new version of MonticelloConfigurations to
>>> > > project The Trunk:
>>> > > http://source.squeak.org/trunk/MonticelloConfigurations-mt.160.mcz
>>> > >
>>> > > ==================== Summary ====================
>>> > >
>>> > > Name: MonticelloConfigurations-mt.160
>>> > > Author: mt
>>> > > Time: 17 April 2020, 5:17:27.82286 pm
>>> > > UUID: 6d32501e-f519-3b4a-ae1a-58b52360a937
>>> > > Ancestors: MonticelloConfigurations-mt.159
>>> > >
>>> > > Shows the current CI status in the update dialog.
>>> > >
>>> > > =============== Diff against MonticelloConfigurations-mt.159
>>> > > ===============
>>> > >
>>> > > Item was changed:
>>> > > ----- Method: MCMcmUpdater>>doUpdate: (in category 'updating') -----
>>> > > doUpdate: interactive
>>> > > "Update the image by loading all pending updates from the server. If
>>> this
>>> > > is
>>> > > the default updater for the system, update the system version when
>>> > > complete.
>>> > > If interteractive use a modal notifier, otherwise only update the
>>> > > transcript.
>>> > > Flush all caches. If a previous download failed this is often
>>> helpful"
>>> > >
>>> > > | config previousUpdateLevel ensureTranscriptSetting |
>>> > > previousUpdateLevel := SystemVersion current highestUpdate.
>>> > > MCFileBasedRepository flushAllCaches.
>>> > > ensureTranscriptSetting := MCConfiguration ensureOpenTranscript.
>>> > > [ MCConfiguration ensureOpenTranscript: interactive.
>>> > > config := self updateFromRepository.
>>> > > config ifNil: [
>>> > > interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from
>>> > > remote repository.' translated ].
>>> > > Transcript cr; show: '========== Unable to retrieve updates from
>>> remote
>>> > > repository. ==========' translated; cr.
>>> > > ^ self ].
>>> > > MCMcmUpdater default == self
>>> > > ifTrue: [
>>> > > config setSystemVersion.
>>> > > + interactive ifTrue: [
>>> > > + self inform: (self updateMessageFor: previousUpdateLevel)].
>>> > > - interactive ifTrue: [
>>> > > - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url:
>>> > > {4}\Map: ''{5}''{6}' translated withCRs format: {
>>> > > - SystemVersion current version.
>>> > > - SystemVersion current highestUpdate.
>>> > > - previousUpdateLevel = SystemVersion current highestUpdate
>>> > > - ifTrue: ['']
>>> > > - ifFalse: [previousUpdateLevel asString, ' -> '].
>>> > > - self repository.
>>> > > - MCMcmUpdater updateMapName.
>>> > > - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d |
>>> String
>>> > > cr, String cr, d]})].
>>> > > Transcript cr;
>>> > > show: '========== Update completed: ' translated;
>>> > > show: previousUpdateLevel;
>>> > > show: ' -> ' ;
>>> > > show: SystemVersion current highestUpdate;
>>> > > show: ' =========='; cr ]
>>> > > ifFalse: [
>>> > > interactive
>>> > > ifTrue: [ self inform: 'Update completed.' ].
>>> > > Transcript cr; show: '========== Update completed. =========='
>>> translated;
>>> > > cr ] ]
>>> > > ensure: [ MCConfiguration ensureOpenTranscript:
>>> ensureTranscriptSetting].
>>> > >
>>> > > !
>>> > >
>>> > > Item was changed:
>>> > > ----- Method: MCMcmUpdater>>doUpdate:upTo: (in category 'updating')
>>> -----
>>> > > doUpdate: interactive upTo: versionNumber
>>> > > "Update the image by loading all pending updates from the server. If
>>> this
>>> > > is
>>> > > the default updater for the system, update the system version when
>>> > > complete.
>>> > > If interteractive use a modal notifier, otherwise only update the
>>> > > transcript.
>>> > > Flush all caches. If a previous download failed this is often
>>> helpful"
>>> > >
>>> > > | config previousUpdateLevel |
>>> > > previousUpdateLevel := SystemVersion current highestUpdate.
>>> > > MCFileBasedRepository flushAllCaches.
>>> > > config := self updateFromRepositories: { self repository } upTo:
>>> > > versionNumber.
>>> > > config ifNil: [
>>> > > interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from
>>> > > remote repository.' translated ].
>>> > > Transcript cr; show: '========== Unable to retrieve updates from
>>> remote
>>> > > repository. ==========' translated; cr.
>>> > > ^ self ].
>>> > > MCMcmUpdater default == self
>>> > > ifTrue: [
>>> > > config setSystemVersion.
>>> > > + interactive ifTrue: [
>>> > > + self inform: (self updateMessageFor: previousUpdateLevel)].
>>> > > - interactive ifTrue: [
>>> > > - self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url:
>>> > > {4}\Map: ''{5}''{6}' translated withCRs format: {
>>> > > - SystemVersion current version.
>>> > > - SystemVersion current highestUpdate.
>>> > > - previousUpdateLevel = SystemVersion current highestUpdate
>>> > > - ifTrue: ['']
>>> > > - ifFalse: [previousUpdateLevel asString, ' -> '].
>>> > > - self repository.
>>> > > - MCMcmUpdater updateMapName.
>>> > > - SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d |
>>> String
>>> > > cr, String cr, d]})].
>>> > > Transcript cr;
>>> > > show: '========== Update completed: ' translated;
>>> > > show: previousUpdateLevel;
>>> > > show: ' -> ' ;
>>> > > show: SystemVersion current highestUpdate;
>>> > > show: ' =========='; cr ]
>>> > > ifFalse: [
>>> > > interactive
>>> > > ifTrue: [ self inform: 'Update completed.' ].
>>> > > Transcript cr; show: '========== Update completed. =========='
>>> translated;
>>> > > cr ]
>>> > > !
>>> > >
>>> > > Item was added:
>>> > > + ----- Method: MCMcmUpdater>>updateMessageFor: (in category
>>> 'private')
>>> > > -----
>>> > > + updateMessageFor: previousUpdateLevel
>>> > > +
>>> > > + ^ ('Update completed.
>>> > >
>>> > > Version: {1}
>>> > > Update: {3}*{2}*
>>> > >
>>> > > Url: {4}
>>> > > Map: ''{5}''
>>> > > TravisCI status: {6}' translated format: {
>>> > > + SystemVersion current version.
>>> > > + SystemVersion current highestUpdate.
>>> > > + previousUpdateLevel = SystemVersion current highestUpdate
>>> > > + ifTrue: ['']
>>> > > + ifFalse: [previousUpdateLevel asString, ' -> '].
>>> > > + self repository.
>>> > > + MCMcmUpdater updateMapName.
>>> > > + SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d |
>>> > > + '
>>> > >
>>> > > ', (d copyReplaceAll: String cr with: '
>>> > > ')].
>>> > > + SystemVersion current ciStatusBadgeUrl.
>>> > > + SystemVersion current ciStatusPageUrl.
>>> > > + }) asTextFromHtml!
>>> > >
>>> > >
>>> > >
>>> > >
>>>
>>>
>>>
>>> >
>>>
>>>
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200511/160b4846/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 37101 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200511/160b4846/attachment.png>


More information about the Squeak-dev mailing list