[squeak-dev] The Inbox: EToys-kfr.414.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Mon Nov 2 16:06:29 UTC 2020


Treated and in Trunk.

Best,
Marcel
Am 02.11.2020 10:26:31 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Karl,

iirc, in Morphic code you should prefer self currentWorld over Project current world. See these guidelines by Marcel: http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-tp5121690p5123334.html [http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-tp5121690p5123334.html] :-)

Best,
Christoph
[http://www.hpi.de/]
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Samstag, 31. Oktober 2020 20:59:05
An: squeak-dev at lists.squeakfoundation.org
Betreff: [squeak-dev] The Inbox: EToys-kfr.414.mcz
 
A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-kfr.414.mcz [http://source.squeak.org/inbox/EToys-kfr.414.mcz]

==================== Summary ====================

Name: EToys-kfr.414
Author: kfr
Time: 31 October 2020, 8:58:48.943742 pm
UUID: 5e186cb9-67d7-124d-901e-ae50d4bacbe8
Ancestors: EToys-eem.413

self world returns nil when the morph is not visible/ opened yet

=============== Diff against EToys-eem.413 ===============

Item was changed:
  ----- Method: CategoryViewer>>assureCategoryFullyVisible (in category '*Etoys-Squeakland-categories') -----
  assureCategoryFullyVisible
         "Keep deleting categoryviewers other than the receiver  until the receiver is fully visible."
 
         | ready toDelete |
         ready := false.
+        [(self bounds bottom > Project current world bottom) and: [ready not]] whileTrue: [
-        [(self bounds bottom > self world bottom) and: [ready not]] whileTrue: [
                 owner submorphs size > 2
                         ifTrue: [
                                 toDelete := owner submorphs allButFirst reversed
                                         detect: [:cv | cv ~~ self]
                                         ifNone: [^ self].
                                 toDelete delete.
                                 self world doOneCycleNow]
                         ifFalse: [
                                 ready := true]].!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201102/5e47efc0/attachment.html>


More information about the Squeak-dev mailing list