> So I don’t understand why we’re moving things en masse to trunk rather than treated inbox.

Because the entire ancestry should be in the same repository, I suppose. Disconnect the merge of some versions from the original versions and I would be fine to move the originals to treated.

Best,
Marcel
Am 04.11.2020 17:44:28 schrieb Eliot Miranda <eliot.miranda at gmail.com>:


On Nov 4, 2020, at 3:01 AM, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:



Hi Nicolas.

> If possible it should be scripted because it's really time consuming to clean up via web interface.

Most of the cases, I suppose, are that copy-vs-move mistake. We do need a "move" button in the MC GUI. 

Agreed.

But I don’t think we should move *any* package from inbox to trunk unless it has already been moved.  The right place for inbox submissions that have been reviewed is the treated inbox.  Why?

A submission to inbox that passes review as is can simply be moved to inbox.  That is the natural thing a reviewer will do.  But occasionally, as has happened with Kernel over the past few days, an inbox submission will need merging.  It is the merge that ends up in trunk.  The original inbox submission may be invalid; at worse it could cause the system to lock up or crash if loaded, say as part of an update test starting from the last release and loading all packages in trunk.

So I don’t understand why we’re moving things en masse to trunk rather than treated inbox.


Best,
Marcel
Am 04.11.2020 11:53:15 schrieb Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>:
Hi Marcel,
months ago, I'm pretty sure that I did similar clean up, but I had the impression that some files did come back...
Such clean-up is very important because any extra file in inbox costs reviewers time which is a very scarce resource.
If possible it should be scripted because it's really time consuming to clean up via web interface.


Le mer. 4 nov. 2020 à 11:44, Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> a écrit :

Hi all!

I just moved over all Kernel Inbox versions that where already in Trunk. Please move, not copy. Thanks! :-)

Best,
Marcel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201104/202b6576/attachment.html>