Hi Marcel!


Would this be a too simple fix for the issue?


In Morph >> #fullDrawOn:

      ...

  "Pass 1: Draw eventual drop-shadow"
-     self hasDropShadow
+ (self hasDropShadow and: [(self ownerSatisfying: #isHandMorph) isNil])
+ ifTrue: [self drawDropShadowOn: aCanvas].

      ....

Best,
Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 9. November 2020 09:01:58
An: squeak-dev
Betreff: Re: [squeak-dev] Drop shadows during grabbing

Hi Christoph.

> I wonder whether we should turn off drop shadows during grabbing a morph?

We already do at some places. See (some) senders of #hasDropShadow:. Still, it feels like a workaround and does not yet apply to the hand's caching procedure. See HandMorph >> #updateCacheCanvas:.

Best,
Marcel

Am 19.09.2020 21:04:28 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:

Hi all,


I wonder whether we should turn off drop shadows during grabbing a morph?

[cid:2b0e9a8e-fc25-455b-9db5-3187ed1fe59f]


And it looks even more strange when grabbing menu items (citing from Squeak by Example):

[cid:258a12de-bd97-46fe-ac1d-7471c6e04160]


This is related to the #menuAppearance3d preference, but I never met a physics system were shadows can throw their own shadows 🤔

Best,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201116/db07b794/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 6693 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201116/db07b794/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 61116 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201116/db07b794/attachment-0003.png>