[squeak-dev] Drop shadows during grabbing

Marcel Taeumel marcel.taeumel at hpi.de
Tue Nov 17 08:44:05 UTC 2020


Hi Christoph.

> Would this be a too simple fix for the issue?

I would not want to do that for every morph. That's the wrong place to fix it. Just take a look at HandMorph and fix the creation of that cached picture.

Best,
Marcel
Am 16.11.2020 16:41:16 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel!

Would this be a too simple fix for the issue?

In Morph >> #fullDrawOn:
      ...
  "Pass 1: Draw eventual drop-shadow"
-     self hasDropShadow
+ (self hasDropShadow and: [(self ownerSatisfying: #isHandMorph) isNil])
+ ifTrue: [self drawDropShadowOn: aCanvas].

      ....

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 9. November 2020 09:01:58
An: squeak-dev
Betreff: Re: [squeak-dev] Drop shadows during grabbing
 
Hi Christoph.

> I wonder whether we should turn off drop shadows during grabbing a morph?

We already do at some places. See (some) senders of #hasDropShadow:. Still, it feels like a workaround and does not yet apply to the hand's caching procedure. See HandMorph >> #updateCacheCanvas:.

Best,
Marcel
Am 19.09.2020 21:04:28 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi all,

I wonder whether we should turn off drop shadows during grabbing a morph?


And it looks even more strange when grabbing menu items (citing from Squeak by Example):


This is related to the #menuAppearance3d preference, but I never met a physics system were shadows can throw their own shadows 🤔


Best,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201117/59f5253b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 6693 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201117/59f5253b/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 61116 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201117/59f5253b/attachment-0003.png>


More information about the Squeak-dev mailing list