[squeak-dev] The Trunk: ToolBuilder-Morphic-ct.252.mcz
Marcel Taeumel
marcel.taeumel at hpi.de
Fri Oct 2 06:32:26 UTC 2020
Hi Chirstoph,
not sure I like the wording #debugFromContextThat:title:. On the plus side, we can remove the explicit reference to #Process.
Maybe consider what is already in the system:
Morph >> #firstOwnerSuchThat:
Object >> #hasLiteralSuchThat:
ChangeList >> #selectSuchThat:
Maybe #debugContextSuchThat:(withTitle:)?
Best,
Marcel
Am 01.10.2020 22:47:49 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,
thank you for reviewing all this stuff! :-)
Might this be a good point to push the discussion from http://forum.world.st/The-Inbox-System-ct-1149-mcz-td5114102.html [http://forum.world.st/The-Inbox-System-ct-1149-mcz-td5114102.html] again? It would allow us to rewrite the #debugAction implementation here as follows:
debugAction
action ifNil: [^ super debugAction].
[self performAction]
debugFromContextThat: [context closure = action]
title: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).
Best,
Christoph
[http://www.hpi.de/]
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Donnerstag, 1. Oktober 2020 16:06 Uhr
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: ToolBuilder-Morphic-ct.252.mcz
Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.252.mcz [http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.252.mcz]
==================== Summary ====================
Name: ToolBuilder-Morphic-ct.252
Author: ct
Time: 20 January 2020, 8:57:46.404972 pm
UUID: 2b311bcc-31ca-dc4d-8ebf-7a1cad07624e
Ancestors: ToolBuilder-Morphic-mt.251
Implement "browse/debug button action" properly on PluggabeButtonMorphPlus
=============== Diff against ToolBuilder-Morphic-mt.251 ===============
Item was added:
+ ----- Method: PluggableButtonMorphPlus>>browseImplementationOfActionSelector (in category 'debug menu') -----
+ browseImplementationOfActionSelector
+
+ action ifNotNil: [
+ ^ action outerContext method browse].
+ ^ super browseImplementationOfActionSelector!
Item was added:
+ ----- Method: PluggableButtonMorphPlus>>debugAction (in category 'debug menu') -----
+ debugAction
+
+ action ifNil: [^ super debugAction].
+ (Process
+ forBlock: [self performAction]
+ runUntil: [:context | context closure = action])
+ debugWithTitle: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201002/98dcb9d5/attachment.html>
More information about the Squeak-dev
mailing list
|