[squeak-dev] The Inbox: Monticello-tobe.729.mcz

Levente Uzonyi leves at caesar.elte.hu
Sun Oct 4 16:07:03 UTC 2020


On Sun, 4 Oct 2020, Tom Beckmann wrote:

> Hi Levente,
> 
> good catch! Yes that would indeed be a better solution. Would you like me to submit a new version to the inbox or will you just move this to treated and create an according version in trunk directly? :)

Whichever you prefer. :)


Levente

> 
> Best,
> Tom
> 
> On Sun, Oct 4, 2020 at 6:00 PM Levente Uzonyi <leves at caesar.elte.hu> wrote:
>       Hi Tom,
>
>       On Sat, 3 Oct 2020, commits at source.squeak.org wrote:
>
>       > A new version of Monticello was added to project The Inbox:
>       > http://source.squeak.org/inbox/Monticello-tobe.729.mcz
>       >
>       > ==================== Summary ====================
>       >
>       > Name: Monticello-tobe.729
>       > Author: tobe
>       > Time: 3 October 2020, 12:57:12.690975 pm
>       > UUID: cbe1a05f-97e6-4780-9762-824be701f76a
>       > Ancestors: Monticello-ul.728
>       >
>       > Include a dot when matching against extensions
>       >
>       > Packages of extension-less formats (e.g. tonel) will otherwise match for e.g. the MCStReader in MCReader>>#canReadFileNamed: if their name happens to end on an "st", e.g. "Roassal3-Sunburst"
>       >
>       > =============== Diff against Monticello-ul.728 ===============
>       >
>       > Item was changed:
>       >  ----- Method: MCVersionReader class>>canReadFileNamed: (in category 'testing') -----
>       >  canReadFileNamed: fileName
>       > +     ^ (fileName endsWith: '.', self extension)!
>       > -     ^ (fileName endsWith: self extension)!
>
>       This is a reasonable change. But the very same method is implemented by
>       the superclass MCReader. So, I think this method should be removed and
>       the change should be applied to MCReader class>>canReadFileNamed:.
>       What do you think?
> 
>
>       Levente
> 
> 
>


More information about the Squeak-dev mailing list