[squeak-dev] Changeset: Eliminating global state from Morphic

marcel.taeumel Marcel.Taeumel at hpi.de
Sun Oct 11 11:54:23 UTC 2020


Hi Christoph.

It's all in Trunk now. ;-) Here are possible next steps:

1. "Project current world" vs. "self currentWorld"

In all packages that should not be dependent from Morphic, use "Project
current world". Otherwise, use "self currentWorld".

2. "self currentWorld" vs. "self world"

In morphs, try to use "self world" whenever possible. Only class-side
methods should use "self currentWorld". Well, if you have code that should
work with morphs not being installed in any world, use "self currentWorld"
because it will fall back to "Project current world".

3. "self currentHand" in non-Morphic packages (ST80, Tools, etc.)

Well, there are some cases where the use of "self currentHand" adds a
dependency to the Morphic package. Not sure whether we can fix this now or
whether we want to extract object-oriented event handling out of Morphic
first to be used in other graphics frameworks such as ST80, SqueakShell,
etc. :-)

Best,
Marcel



Christoph Thiede wrote
> Hi Marcel,
> 
> 
> thanks for reviewing and splitting up the changes! I confirm that two
> members of my image farm survived the recent patches without any problem.
> :D
> 
> 
> Best,
> 
> Christoph
> 
> <http://www.hpi.de/>
> ________________________________
> Von: Squeak-dev <

> squeak-dev-bounces at .squeakfoundation

> > im Auftrag von Taeumel, Marcel
> Gesendet: Donnerstag, 8. Oktober 2020 17:20:26
> An: squeak-dev
> Betreff: Re: [squeak-dev] Changeset: Eliminating global state from Morphic
> 
> Hi Christoph, hi all!
> 
> The first part of this refactoring is in the Trunk. Please try updating
> your images and report back!
> http://forum.world.st/The-Trunk-Morphic-mt-1697-mcz-td5123173.html
> 
> If all went well, I will commit the second part, too, which will remove
> all remaining references to ActiveWorld etc.
> 
> Best,
> Marcel
> 
> Am 30.09.2020 18:22:43 schrieb Thiede, Christoph <

> christoph.thiede at .uni-potsdam

> >:
> 
> This version includes a test method, #testActiveVariablesObsoletion, that
> makes sure that no one will try to reference one of the deprecated
> ActiveVariable bindings again in the future. Thanks to Marcel for the tip!
> 
> 
> Best,
> 
> Christoph
> 
> ________________________________
> Von: Squeak-dev <

> squeak-dev-bounces at .squeakfoundation

> > im Auftrag von Thiede, Christoph
> Gesendet: Mittwoch, 30. September 2020 17:50:43
> An: The general-purpose Squeak developers list
> Betreff: Re: [squeak-dev] Changeset: Eliminating global state from Morphic
> 
> 
> Here is another version of the changeset that does not even longer raise a
> debugger when removing the current hand.
> 
> 
> Best,
> 
> Christoph
> 
> ________________________________
> Von: Squeak-dev <

> squeak-dev-bounces at .squeakfoundation

> > im Auftrag von Thiede, Christoph
> Gesendet: Mittwoch, 30. September 2020 11:40:05
> An: The general-purpose Squeak developers list
> Betreff: Re: [squeak-dev] Changeset: Eliminating global state from Morphic
> 
> 
> Hm, probably we should integrate the "filein without UI updates" option
> into the FileList menu, too ...?
> 
> 
> Best,
> 
> Christoph
> 
> <http://www.hpi.de/>
> ________________________________
> Von: Squeak-dev <

> squeak-dev-bounces at .squeakfoundation

> > im Auftrag von David T. Lewis <

> lewis at .msen

> >
> Gesendet: Mittwoch, 30. September 2020 02:22:06
> An: The general-purpose Squeak developers list
> Betreff: Re: [squeak-dev] Changeset: Eliminating global state from Morphic
> 
> On Mon, Sep 28, 2020 at 10:55:45AM +0000, Thiede, Christoph wrote:
>> Hi all,
>>
>>
>> Dave, I double-checked it. When loading the second changeset, can you
>> confirm that you used the new option in the drop handler dialog?
>>
>>
>> [cid:3848a1c6-d67f-4999-a714-ffafff2b4a22]
>>
> 
> No, I did definitely not do that. I opened a FileList and selected the
> change sets one at a time, and clicked install for each. Installing the
> second change set locked the image.
> 
> After reading your email, I did this:
> 
> 1) Forwarded your email to my 

> dtlewis290@

>  (spam oriented) account
> so I could view the graphic attachment, which showed that you are using
> drag and drop when you load the change sets.
> 
> 2) Opened a GUI file browser on my Ubuntu laptop, and used drag and drop
> to copy the two change sets to my image.
> 
> 3) On dropping the second change set into the image, I selected the
> "... without updating UI" option.
> 
> That worked.
> 
> Dave





--
Sent from: http://forum.world.st/Squeak-Dev-f45488.html


More information about the Squeak-dev mailing list