New day, new thoughts on this matter. I don't think that having extra #reset... messages for pragma preferences is necessary. The getter as "ifNil" and so should the setter support a 'nil' argument to reset. I will update those remaining 20% of setters to support 'nil' as argument.

Best,
Marcel
Am 15.10.2020 12:59:57 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Hmm... not sure how that happened. Maybe because I did that from a Vivide image. Well, no worries. I will use a fresh Trunk image as catalyst. :-)

Best,
Marcel
Am 14.10.2020 20:32:49 schrieb Eliot Miranda <eliot.miranda at gmail.com>:


On Wed, Oct 14, 2020 at 8:03 AM Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> wrote:

Hi all!

Please find attached a change set that will implement #restoreDefaultValue on PragmaPreference looking for an optional #reset... message or just setting the preference to 'nil' and hoping for the best.

I added #reset... methods for all pragma preferences that do either (a) not support 'nil' or (b) do costly update stuff.

In the ReleaseBuilder, I opted for resetting all preferences as early as possible.

Can I put this in the Trunk? :-)

Yes, but only if you remove all those stylings ;-)  I don't want y changes file filling up with junk that will be auto-styled over :-)

_,,,^..^,,,_

best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201015/76cfde33/attachment.html>