[squeak-dev] The Inbox: Compiler-tobe.448.mcz

Eliot Miranda eliot.miranda at gmail.com
Sat Oct 17 09:19:25 UTC 2020



> On Oct 17, 2020, at 12:11 AM, commits at source.squeak.org wrote:
> 
> A new version of Compiler was added to project The Inbox:
> http://source.squeak.org/inbox/Compiler-tobe.448.mcz
> 
> ==================== Summary ====================
> 
> Name: Compiler-tobe.448
> Author: tobe
> Time: 17 October 2020, 9:11:04.555834 am
> UUID: 0827d6fb-39db-4734-8440-9c0af90b39e5
> Ancestors: Compiler-eem.447
> 
> Report pc for closureCreationNodes of full blocks
> 
> See BlockNode>>#emitCodeForValue:encoder: for the analogous call without full blocks
> 
> =============== Diff against Compiler-eem.447 ===============
> 
> Item was changed:
>  ----- Method: BlockNode>>emitCodeForFullBlockValue:encoder: (in category 'code generation') -----
>  emitCodeForFullBlockValue: stack encoder: encoder
>      copiedValues do:
>          [:copiedValue| copiedValue emitCodeForValue: stack encoder: encoder].
> +    closureCreationNode pc: encoder nextPC.
>      encoder
>          genPushFullClosure: closureCreationNode index
>          numCopied: copiedValues size.
>      stack
>          pop: copiedValues size;
>          push: 1!


Looks right to me.  Push it to trunk...


More information about the Squeak-dev mailing list