[squeak-dev] Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

gettimothy gettimothy at zoho.com
Fri Oct 23 12:57:03 UTC 2020


Hi Tom,





The problem has re-introduced itself during the Roassal3 installation process.



I will try to isolate the exact point.





BoxedFloat64 infinity  Infinity





(BoxedFloat64 infinity) >= 1  false





(BoxedFloat64 infinity) < 1  true







cordially,



t






---- On Fri, 23 Oct 2020 01:42:52 -0400 Tom Beckmann <tomjonabc at gmail.com> wrote ----


Hi timothy,



here, too, I don't observe any issues. Is it possible that you loaded some Number/Math package from Pharo that could have introduced erroneous overrides?



All tests from Roassal3-Animation pass for me, except two that assume that `3 second` returns `0:00:03`, which it does in Pharo, while in Squeak it always returns `0:00:01`. Not sure which behavior I like more (I think I would personally prefer Squeak's behavior, iff it threw an error when I run `3 second` instead of silently discarding the two seconds). Regardless of that we should propose to change it to `#seconds`, as Roassal uses `#seconds` everywhere else in their code when referring to time spans >1 second.



Best,

Tom



On Thu, Oct 22, 2020 at 10:07 PM Vanessa Freudenberg <mailto:vanessa at codefrau.net> wrote:

What does "BoxedFloat64 infinity print?



And what VM are you on? 32 or 64 bits?



FWIW, it works fine on this VM:



Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-nice.2715] 64 bit
 Mac OS X built on Mar  3 2020 08:28:30 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)
 platform sources revision VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
 CoInterpreter VMMaker.oscog-nice.2715 uuid: 78e2f556-9829-42fe-963d-e19dfc43c0e9 Mar  3 2020
 StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar  3 2020



- Vanessa -



On Thu, Oct 22, 2020 at 7:51 AM gettimothy via Squeak-dev <mailto:squeak-dev at lists.squeakfoundation.org> wrote:

Hi folks,



Version: Squeak6.0alphaUpdate: 20010




Working through the Roassal3 tests  

in RSAbstractAnimation>>loops: aNumber

self assert: aNumber >= 1 description: 'The number of times to repeat this animation'.    <----test fails here.

loops := aNumber



aNumber is Infinity (inspecting displays a Boxed Float)



Poking around a bit...



(BoxedFloat64 infinity) >= 1  -> false




then....



(BoxedFloat64 infinity) < 1 ->true




Is this expected?



If so, suggestions on how  I should I make the test reflect reality?



thx in advance.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201023/6f97249e/attachment.html>


More information about the Squeak-dev mailing list