Can we make SystemNavigation >> #headingAndAutoselectForLiteral:do: non-private?

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Mittwoch, 2. September 2020 16:55:49
An: squeak-dev at lists.squeakfoundation.org
Betreff: [squeak-dev] The Inbox: Tools-ct.986.mcz

Christoph Thiede uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.986.mcz

==================== Summary ====================

Name: Tools-ct.986
Author: ct
Time: 2 September 2020, 4:55:38.538083 pm
UUID: b4cdf611-f04b-0b40-8f61-34429f414cca
Ancestors: Tools-ct.985

Fixes MNU when adding senders of a non-string literal to a message trace (at the end, FindText was set to a number or something similar). Improves multilingual support.

=============== Diff against Tools-ct.985 ===============

Item was changed:
  ----- Method: MessageTrace>>addParentMethodsSending: (in category 'building') -----
  addParentMethodsSending: selectorSymbol

+        ^ self systemNavigation
+                headingAndAutoselectForLiteral: selectorSymbol
+                do: [:label :autoSelect |
+                        | methodsList |
+                        methodsList := self systemNavigation allCallsOn: selectorSymbol.
+                        methodsList ifEmpty: [
+                                ^ self inform: ('There are no {1}' translated format: {label})].
+                        self
-        | methodsList |
-        (methodsList := self systemNavigation allCallsOn: selectorSymbol) isEmpty
-                ifTrue:
-                        [ ^(PopUpMenu labels: ' OK ')
-                                startUpWithCaption: 'There are no methods that send ', selectorSymbol ]
-                ifFalse:
-                        [ self
                                 addParentMessages: methodsList
+                                autoSelectString: autoSelect]
-                                autoSelectString: selectorSymbol ]
  !


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200902/a0fe6939/attachment.html>