Hi Subbu,


> What if a START log is lazily written just before the first write to the change log?
>
> If no changes are made then the changes file remains untouched. The first write to the change log is prefixed with a START log entry. A QUIT/NO SAVE entry is not needed or may be added if and only if a START log was written.

-1. :-) I think Chris found exactly the right words about an important drawback of such behavior:


> Not logging when there is no change sounds reasonable at first blush, but there are also Squeak systems that run a fixed image that don't save on exit -- it may be useful for operators of those systems to be able to know when there were interactions with the system, regardless whether development causing .changes changes was done or not.

IMO this sounds like something that you should be able to control via a special VM flag:


./squeak my.image --quite-changes-logging # Does not write startup/shutdown messages to the changes file


Best,

Christoph

<http://www.hpi.de/>
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Eliot Miranda <eliot.miranda at gmail.com>
Gesendet: Sonntag, 13. September 2020 18:25:10
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] a few small quit issues I want to note

Hi Subbu,

> On Sep 13, 2020, at 4:27 AM, K K Subbu <kksubbu.ml at gmail.com> wrote:
>
> On 12/09/20 8:01 pm, Eliot Miranda wrote:
>> That makes sense.  So we do want the QUIT/NO SAVE indication written to the changes file if anything is written to the changes file because we know that when doing crash recovery we want to ignore everything before QUIT/NO SAVE.  So, Chris Muller’s objections aside, I would argue that if the changes file is undisturbed (nothing written to it in the current session) when the system is about to quit without saving, it should do so without writing the QUIT/NO SAVE stamp.
>
> What if a START log is lazily written just before the first write to the change log?
>
> If no changes are made then the changes file remains untouched. The first write to the change log is prefixed with a START log entry. A QUIT/NO SAVE entry is not needed or may be added if and only if a START log was written.

Good idea. That would work.

>
> Regards .. Subbu
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200914/ef5e0dec/attachment.html>