PluggableCheckBoxMorph is just as wrapper for UpdatingThreePhaseButtonMorph
afaics.
My issue was ToolBuilders use of symbols instead of strings for the label.
I just made a method in FontChooserTool that returned the label as a string.

Best,
Karl

On Mon, Sep 28, 2020 at 9:28 AM Marcel Taeumel <marcel.taeumel at hpi.de>
wrote:

> Hi Karl.
>
> We might want to merge the behavior of those:
>
> PluggableCheckBoxMorph
> ThreePhaseButtonMorph class >> #checkBox
>
> Best,
> Marcel
>
> Am 26.09.2020 19:20:10 schrieb karl ramberg <karlramberg at gmail.com>:
> Figured this out...
> Best,
> Karl
>
> On Sat, Sep 26, 2020 at 10:41 AM karl ramberg <karlramberg at gmail.com>
> wrote:
>
>> Hi,
>> I tested using PluggableCheckBoxMorph but that widget is unwieldy.
>> I'm not sure how to add a label to it.
>> The widget seem to expect the model eg. FontChooserTool to perform the
>> label ?
>>
>> PluggableCheckBoxMorph>>on: anObject getState: getStateSel action:
>> actionSel label: labelSel menu: menuSel
>> ...
>> self label: (self model perform: labelSel).
>>
>> I'm not sure how that is supposed to work...
>>
>> There is no other use of the widget in the image I can look at either.
>>
>> Best,
>> Karl
>>
>> On Tue, Sep 8, 2020 at 9:57 PM Thiede, Christoph <
>> Christoph.Thiede at student.hpi.uni-potsdam.de> wrote:
>>
>>> Great ideas! I never get the right handle on the first try, merging them
>>> sounds very reasonable. :-)
>>>
>>> Hm ... doesn't the existence of such an "Apply" button impede Morphic's
>>> liveness? Why not just apply all changes as soon as a font/style has been
>>> selected? You could replace the buttons by a checkbox "selection only".
>>>
>>>
>>> Best,
>>>
>>> Christoph
>>>
>>> ------------------------------
>>> *Von:* Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im
>>> Auftrag von karl ramberg <karlramberg at gmail.com>
>>> *Gesendet:* Dienstag, 8. September 2020 21:49 Uhr
>>> *An:* The general-purpose Squeak developers list
>>> *Betreff:* Re: [squeak-dev] Inspector Custom Value Panes & Related
>>>
>>>
>>>
>>> On Tue, Sep 8, 2020 at 8:16 AM Thiede, Christoph <
>>> Christoph.Thiede at student.hpi.uni-potsdam.de> wrote:
>>>
>>>> Hi Karl,
>>>>
>>>>
>>>> I'm sorry your proposal is lost a bit - I think it's a nice addition!
>>>> It does not look exactly like the TextMorph dialog, but I actually prefer
>>>> "one dialog that fits it all" over the three separate handles for a
>>>> TextMorph (that do not even all appear to work properly at the moment.) I
>>>> think we should get this merged! :-)
>>>>
>>>>
>>>> My change just adds handle support to the already existing
>>> StringMorph>>changeFont
>>>
>>> The three TextMorph handles are not optimal and could be refactored into
>>> one handle.
>>>
>>> I made another change  to FontChooserTool where I added a button to
>>> apply text changes to the partition of text selected or a bulk change to
>>> all text in the pane. With this change I also enabled the emphasis pane to
>>> FontChooserTool.
>>>
>>> [image: bild.png]
>>>
>>> Best,
>>> Karl
>>>
>>>
>>> Best,
>>>>
>>>> Christoph
>>>> <http://www.hpi.de/>
>>>> ------------------------------
>>>> *Von:* Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im
>>>> Auftrag von karl ramberg <karlramberg at gmail.com>
>>>> *Gesendet:* Donnerstag, 3. September 2020 13:28:41
>>>> *An:* The general-purpose Squeak developers list
>>>> *Betreff:* Re: [squeak-dev] Inspector Custom Value Panes & Related
>>>>
>>>> Here is a change set that adds HaloHandle for font change to StringMorph
>>>>
>>>> Best,
>>>> Karl
>>>>
>>>> On Thu, Sep 3, 2020 at 9:56 AM Marcel Taeumel <marcel.taeumel at hpi.de>
>>>> wrote:
>>>>
>>>>> Hi Eric.
>>>>>
>>>>> > What is the proper way to make a "custom value pane" for my objects
>>>>> whenever they appear inside an Inspector?
>>>>>
>>>>> Unfortunately, the current inspector framework has no such extension
>>>>> point. You can, however, prepare a custom inspector for your domain
>>>>> objects. See MorphInspector as an example.
>>>>>
>>>>> Best,
>>>>> Marcel
>>>>>
>>>>> Am 02.09.2020 00:10:56 schrieb Eric Gade <eric.gade at gmail.com>:
>>>>> Hi all,
>>>>>
>>>>> What is the proper way to make a "custom value pane" for my objects
>>>>> whenever they appear inside an Inspector? For my RISCV work, I'm looking to
>>>>> show a morphic representation of the bitfields when a given instruction's
>>>>> `self` property is highlighted in the Inspector window.
>>>>>
>>>>> As a related question, what's the best way to make a composed Morph
>>>>> that has StringMorphs of different fonts, sizes, and alignments? It seems
>>>>> like not all Fonts are available to StringMorph (TrueType ones, for
>>>>> example) -- is that correct?
>>>>>
>>>>> Thanks!
>>>>>
>>>>> --
>>>>> Eric
>>>>>
>>>>>
>>>>>
>>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200928/6176ba5f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bild.png
Type: image/png
Size: 21823 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200928/6176ba5f/attachment-0001.png>