> Personally, I'd prefer a preference for this.

You would only need a preference or confirmation dialog if we fail to implement it correctly. ;-) The goal would be that your content does not get messed up when detecting a DPI change.

Best,
Marcel
Am 30.09.2020 12:21:37 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Tobias,


> > For the first step, we could start by asking the user whether they would like to change the font size (#changeFontSize:) when a new scale factor is detected, couldn't we?
> 
> No, that ought to be automatic;

Personally, I'd prefer a preference for this. ;-) My Windows system often changes its DPI value multiple times a day and #changeFontSize: has a big impact on your image as it replaces the UI theme (for example, all windows are resized and repositioned, custom theme adjustments are lost, the search bar [http://forum.world.st/BUG-Updating-TheWorldMainDockingBar-leaves-dangling-results-widgets-td5110474.html] is emptied, and the history of workspaces is cleared). Also, it's an expensive operation that can slow my system down for ca. 10 seconds per open image. I would only change the font size if I need it just at the moment (I always use to keep open several images even if I do not use all of them frequently).

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux at gmx.de>
Gesendet: Dienstag, 29. September 2020 10:28:01
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] highdpi testing
 
Hi
> On 25.09.2020, at 21:43, Thiede, Christoph <Christoph.Thiede at student.hpi.uni-potsdam.de> wrote:
>
> Hi Tobias,
>
> sorry I did not answer earlier! This approach looks better for me, however, the wheel is still not absolutely round:
>
>
> (The shadows have a wrong position.)

I know, I had a patch that worked in 2016, but things changed and I hand't had the time yet.

>
> For the first step, we could start by asking the user whether they would like to change the font size (#changeFontSize:) when a new scale factor is detected, couldn't we?

No, that ought to be automatic;

-t


>
> PS: @Tom:
> > we try drawing things while we load things :)
> For the case you did not already read it, I created a changeset that could solve this problem: http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-tp5121690p5122464.html [http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-tp5121690p5122464.html] It also allow me to file in the original DpiAware changeset.
>
> Best,
> Christoph
> Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Tobias Pape <Das.Linux at gmx.de>
> Gesendet: Montag, 21. September 2020 15:50:30
> An: The general-purpose Squeak developers list
> Betreff: Re: [squeak-dev] highdpi testing
> 
> Hi
>
> > On 19.09.2020, at 19:26, Thiede, Christoph <Christoph.Thiede at student.hpi.uni-potsdam.de> wrote:
> >
> > Hi,
> >
> > ah, I had assumed something like this, thanks for fixing, Tom! :-)
> >
> > #actualScreenScaleFactor is a very helpful tool, but I do not yet see the whole idea of the changeset.
> > In what sense is this meant to be a complement of RealEstateAgent >> #scaleFactor or rather an orthogonal concept?
> > After loading the changeset and resetting my UI theme, the background image of the world disappeared and all new windows are huge, but they still have a tiny font - am I supposed to set the #scaleFactor manually (to 12, in my example)?
> > Where exactly can I see any components in the image that are upscaled by the new changeset?
> >
>
> These do something.
> Load in order:
>
> DpiAware-Kernel
> DpiAware-Morpic
> DpiAware-Display
>
> First two are harmless, third will do something.
> If nothing changes, do
>         UserInterfaceTheme cleanUpAndReset.
>
> Issues ensue.
> - Layouting borks.
>         The assert after the potential relayout
>                 self assert: (self hasProperty: #doLayoutAgain) not
>         fails already in the docking bar…
> - Fonts with UI-Themes do not work.
>   These are "Deep-referenced" to a pixel size (for Strike fonts) on creation, (so also during UserInterfaceTheme cleanUpAndReset).
>   However, when the scale factor changes, the pixel-sized fonts don't match the point sizes anymore…
>     This used to work pre-UI-Themes, as everyone requesting a Font did so by directly asking StrikeFont or TextStyle at the time the
>   Font was used. Hummm..
>
> Hope you enjoy.
> -t



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200930/f5c60386/attachment.html>