[squeak-dev] "Browse revisions" server error for long methods

Vanessa Freudenberg vanessa at codefrau.net
Sat Apr 17 23:20:17 UTC 2021


Well, class + selector + author initials / time stamp should be enough to
identify the method on the server. Sending the whole source code with it
seems unnecessary.

–Vanessa –

On Sat, Apr 17, 2021 at 06:04 Marcel Taeumel <marcel.taeumel at hpi.de> wrote:

> +1 for using POST (if it is easier to implement... Chris?)
>
> Best,
> Marcel
>
> Am 17.04.2021 05:11:17 schrieb Vanessa Freudenberg <vanessa at codefrau.net>:
> The argument to the server call is serializing the whole definition:
>
> serializeForRequest: aMCDefinition
> ^ ((ReferenceStream on: (RWBinaryOrTextStream on: ByteArray new)) nextPut:
> aMCDefinition ; yourself) contents asString encodeForHTTP
>
> So either, as Levente suggests, it needs to be POSTed which allows larger
> data, or something smaller needs to be posted to the server, like
> MCDefinition>>description. Either way, it sounds like both server and
> client need to be touched for this.
>
> –Vanessa–
>
> On Fri, Apr 16, 2021 at 4:17 PM Levente Uzonyi <leves at caesar.elte.hu>
> wrote:
>
>> The problem is that the service is implemented as a GET request instead
>> of a POST or PUT request, so data can only be encoded in the URL.
>> Like most web servers, nginx has an upper limit on the length of the URLs
>> accepted (though it's implicit in case of nginx).
>> And even though the accepted maximum length could be increased, there
>> would still be cases where the error occurs.
>> The right solution is to implement this as a POST or a PUT service.
>>
>>
>> Levente
>>
>> On Fri, 16 Apr 2021, Christoph Thiede wrote:
>>
>> > Hmm ... Confusingly, the error message still persists when I manually
>> > truncate the source in the method definition. On the other hand, the
>> feature
>> > works fine for other methods such as String >> #asInteger. Is the
>> request
>> > limit just way too low? Could you maybe increase this limitation?
>> >
>> > Best,
>> > Christoph
>> >
>> >
>> >
>> > -----
>> > Carpe Squeak!
>> > --
>> > Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210417/d1d10e85/attachment.html>


More information about the Squeak-dev mailing list