I see only a minor problem with this version:

it breaks testRunSimulatedContextAtEachStep.
This test did profit by polymorphism of asContext to use a Context
instead of a Block(Closure).
But Context does no understand asContextWithSender:

Maybe more a problem of the test itself than of the proposed change.


Le jeu. 15 avr. 2021 à 11:52, Nicolas Cellier
<nicolas.cellier.aka.nice at gmail.com> a écrit :
>
> I mean authorship...
>
> Le jeu. 15 avr. 2021 à 11:50, Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com> a écrit :
>>
>> With the merge commit that would make 3 commits for a single method. My plan is to cherry pick the change on top of trunk with proper comment. With our tools, ownership is preserved anyway :)
>>
>> Le jeu. 15 avr. 2021 à 11:05, Marcel Taeumel <marcel.taeumel at hpi.de> a écrit :
>>>
>>> Hi Nicolas,
>>>
>>> ct.1363 depends on ct.1362, the latter being easier to review. Maybe Christoph (ct) can point us to the "request" he mentioned in the message in 1363. Yet, it looks like Eliot (indirectly) approved this already: http://forum.world.st/The-Inbox-Kernel-ct-1362-mcz-tp5124354.html ..? Or at least he planned to look at this.
>>>
>>> (Let's hope that the words "branch commit" do not hide more dependencies. Not sure what it means here.)
>>>
>>> Best,
>>> Marcel
>>>
>>> Am 15.04.2021 10:48:09 schrieb Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>:
>>>
>>> Hi all,
>>> again a good and difficult to analyze contribution.
>>> We mostly send runSimulated:contextAtEachStep: to thisContext, except
>>> in one case in base image:
>>>
>>> MessageTally tallySends: [3.14159 printString]
>>>
>>> This is effectively broken in trunk, and repaired after applying Kernel-ct.1363.
>>> Before I merge this, additional advice is welcome, this is a tough
>>> subject, breaking the Debugger would be the last thing we want to do.
>>>
>>>