[squeak-dev] The Trunk: Morphic-mt.1767.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Apr 30 08:11:15 UTC 2021


Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1767.mcz

==================== Summary ====================

Name: Morphic-mt.1767
Author: mt
Time: 30 April 2021, 10:11:09.230936 am
UUID: ebeb7f55-0ca6-a04c-8b5c-87008f09c697
Ancestors: Morphic-mt.1766

Now that I recently discovered the various ways to browse changes ... make the (rather new) changes menu in the docking bar feel more complete.

Note that I have no real clue on the actual uses of browsing single change sets or sets of changed methods. Maybe you can help me with some experience reports so that we might remove one or the other menu item again.

=============== Diff against Morphic-mt.1766 ===============

Item was added:
+ ----- Method: TheWorldMainDockingBar>>browseChangeSet (in category 'submenu - changes') -----
+ browseChangeSet
+ 
+ 	ChangeSetBrowser openOnCurrent.!

Item was added:
+ ----- Method: TheWorldMainDockingBar>>browseChangedMethods (in category 'submenu - changes') -----
+ browseChangedMethods
+ 
+ 	ChangedMessageSet openFor: ChangeSet current.!

Item was added:
+ ----- Method: TheWorldMainDockingBar>>browseChangesDual (in category 'submenu - changes') -----
+ browseChangesDual
+ 
+ 	DualChangeSorter open.!

Item was changed:
  ----- Method: TheWorldMainDockingBar>>listChangesOn: (in category 'submenu - changes') -----
  listChangesOn: menu
  
  	| latestMethodChanges latestClassChanges|
  	latestMethodChanges := (Array streamContents: [:s |
  		ChangeSet current changedMethodsDo: [:method :changeType :dateAndTime :category |
  			s nextPut: { dateAndTime. method. changeType. category }]])
  			sorted: [:a :b | a first >= b first].
  
  	1 to: (10 min: latestMethodChanges size) do: [:index | | spec method |
  		spec := latestMethodChanges at: index.
  		method := spec second.
  		menu addItem: [:item |
  			item
  				contents: ('{1} {2} \{{3}\} \{{4}\}' format: {method methodClass. method selector. spec fourth. method methodClass category}) ;
  				target: ToolSet;
  				balloonText: spec third asString;
  				icon: ((#(remove addedThenRemoved) includes: spec third) ifTrue: [MenuIcons smallDeleteIcon] ifFalse: [
  					spec third = #add ifTrue: [MenuIcons smallNewIcon] ifFalse: [MenuIcons blankIcon]]);
  				selector: (method isInstalled ifTrue: [#browseMethod:] ifFalse: [#browseMethodVersion:]);
  				arguments: {method}]].
  				
  	latestClassChanges := (Array streamContents: [:s |
  		ChangeSet current changedClassesDo: [:class :changeTypes :dateAndTime :category |
  			"We are not interested in classes whose method's did only change."
  			changeTypes ifNotEmpty: [s nextPut: { dateAndTime. class. changeTypes. category }]]])
  			sorted: [:a :b | a first >= b first].
  
  	latestClassChanges ifNotEmpty: [menu addLine].
  	1 to: (10 min: latestClassChanges size) do: [:index | | spec class |
  		spec := latestClassChanges at: index.
  		class := spec second.
  		menu addItem: [:item |
  			item
  				contents: ('{1} \{{2}\}' format: {class name. spec fourth }) ;
  				target: ToolSet;
  				balloonText: (spec third sorted joinSeparatedBy: Character space);
  				icon: ((spec third includesAnyOf: #(remove addedThenRemoved))
  					ifTrue: [MenuIcons smallDeleteIcon]
  					ifFalse: [
  						(spec third includes: #add)
  							ifTrue: [MenuIcons smallNewIcon]
  							ifFalse: [MenuIcons blankIcon]]);
  				selector: ((spec third includes: #remove) ifTrue: [#inspect:] ifFalse: [#browseClass:]);
  				arguments: {class}]].
+ 	
+ 	menu defaultTarget: self.
+ 	menu addTranslatedList: #(
+ 		-
+ 		('Browse current change set'		browseChangeSet)
+ 		('Browse changed methods'		browseChangedMethods)
+ 		-
+ 		('Simple Change Sorter'				browseChanges)
+ 		('Dual Change Sorter'					browseChangesDual)).
+ 
+ 
+ !
- 				
- 	menu addLine; addItem: [:item |
- 		item
- 			contents: 'Browse current change set...' translated;
- 			target: self;
- 			selector: #browseChanges].!

Item was changed:
+ (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances..'!
- (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances.'!



More information about the Squeak-dev mailing list