[squeak-dev] The Trunk: System-mt.1262.mcz

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Thu Dec 2 17:27:58 UTC 2021


Looks good to me (although I am not a native speaker)! :-)


Just one question, do you think it would it be useful to already mention the naming convention (firstName.lastName) in the first dialog?


Best,

Christoph


(PS: Funnily, when you quoted the announcement message from commits at source.squeak.org, your client has evaluated the HTML strings from the patch. :D)

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 2. Dezember 2021 16:15:01
An: squeak-dev
Betreff: Re: [squeak-dev] The Trunk: System-mt.1262.mcz

[cid:57cbef56-3f58-4f70-9531-dddf7659dff9]

;o)

(Is the wording okay? Any tips from native speakers .. err.. squeakers?)

Am 02.12.2021 16:13:22 schrieb commits at source.squeak.org <commits at source.squeak.org>:

Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.1262.mcz

==================== Summary ====================

Name: System-mt.1262
Author: mt
Time: 2 December 2021, 4:13:05.311715 pm
UUID: 777eacd2-3987-4b40-9431-85e1eb125748
Ancestors: System-dtl.1261

When the system asks you for your author intials, cross-check against the list of known contributors. If there is a match, greet the user and ask if the match is correct. Encourage the user to enter "firstname.lastname" as author initials to avoid conflicts with older initials.

Thanks to Christoph (ct) for the idea!

Try to derive #authorName from #authorInitials and vice versa using the list of known contributors.

Minor tweak of the text layout for the version's alpha-warning text.

=============== Diff against System-dtl.1261 ===============

Item was changed:
----- Method: SystemVersion>>description (in category 'printing') -----
description

+ self isAlpha ifTrue: [^ 'ALPHA. New features which are not stable yet may come in\with each update. Also, existing features might not work\reliably due to updates and related changes.' translated withCRs].
- self isAlpha ifTrue: [^ 'ALPHA. New features which are not stable yet may come in\with each update. Also, existing features might not work reliably\due to updates and related changes.' translated withCRs].

(self isFeatureFreeze and: [self isCodeFreeze not]) ifTrue: [^ 'FEATURE FREEZE. A new release is being prepared.\There will be only bugfixes, but no new features.' translated withCRs].

self isCodeFreeze ifTrue: [^ 'RELEASE CANDIDATE. The new release is almost ready.\There will be only bugfixes, if any.' translated withCRs].

self isRelease ifTrue: [^ ''].!

Item was changed:
----- Method: Utilities class>>authorInitials (in category 'identification') -----
authorInitials
+ "Maybe interactive. Answer the initials to be used to identify the current code author. Ask the user if the initials are empty. Try to derive the initials from the existing author name."
- "Answer the initials to be used to identify the current code author. "

+ (AuthorInitials isEmpty and: [AuthorName notEmpty])
+ ifTrue: [
+ SystemNavigation authors
+ at: AuthorName
+ ifPresent: [:authorInitials |
+ AuthorInitials := authorInitials anyOne. "Can be multiple matches"
+ self setAuthorInitials "Let the user confirm"]].
+
[AuthorInitials isEmpty] whileTrue: [self setAuthorInitials].
^ AuthorInitials!

Item was changed:
----- Method: Utilities class>>authorName (in category 'identification') -----
authorName
+ "Maybe interactive. Answer the full name to be used in various tools to identify the user/author. Ask the user if the name is empty. Try to derive the name from existing initials."
+
+ ^ AuthorName ifEmpty: [
+ AuthorInitials
+ ifEmpty: [self setAuthorName. AuthorName]
+ ifNotEmpty: [:initials |
+ SystemNavigation authorsInverted
+ at: initials
+ ifPresent: [:authorNames |
+ AuthorName := authorNames sorted joinSeparatedBy: '/'.
+ self setAuthorName. "Let the user confirm"]
+ ifAbsent: [self setAuthorName. AuthorName]]]!
- AuthorName ifEmpty: [self setAuthorName].
- ^ AuthorName!

Item was changed:
----- Method: Utilities class>>setAuthorInitials (in category 'identification') -----
setAuthorInitials
+ "Put up a dialog allowing the user to specify the author's initials. Inform the user about collisions with known contributors. See SystemNavigation class >> #authors. "
- "Put up a dialog allowing the user to specify the author's initials. "

+ | newInitials newName |
+ newInitials := Project uiManager
+ request: 'Please type your initials:' translated
+ initialAnswer: AuthorInitials.
+
+ SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames |
+ newName := existingNames sorted joinSeparatedBy: '/'].
+
+ (self confirm: ('Hello, {1}!! :-)

Our list of known contributors associates the initials you
have entered with this name. If this is not you, please
consider entering alternative initials, preferably in the
format firstName.lastName to avoid collisions.<code://{3}>

Are these your author initials?

{2}' translated format: {
+ newName ifNil: [newInitials].
+ newInitials.
+ 'SystemReporter open model categoryAt: 1 put: true'.
+ Preferences standardButtonFont familyName.
+ Preferences standardButtonFont pointSize.
+ "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346.html"
+ 'a' }) asTextFromHtml)
+
+ ifTrue: [self authorInitials: newInitials].!
- self authorInitials:
- (UIManager default request: 'Please type your initials: ' translated
- initialAnswer: AuthorInitials)!

Item was changed:
----- Method: Utilities class>>setAuthorName (in category 'identification') -----
setAuthorName
+
+ AuthorName := Project uiManager
+ request: 'Please type your name:' translated
+ initialAnswer: (AuthorName ifEmpty: ['Your Name' translated]).!
- AuthorName := UIManager default
- request: 'Please type your name:' translated
- initialAnswer: 'Your Name' translated!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211202/ff44cc21/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 29078 bytes
Desc: image.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211202/ff44cc21/attachment-0001.png>


More information about the Squeak-dev mailing list