Hi Chris --

Thanks for your thoughts. There clearly seems to be a conflict of interest here due to platform issues we cannot solve in the short term. I am interested in helping all interested parties.

> A much better solution would be for Cmd+z to simply Undo back to the last state prior to Cmd+l being pressed.

Hmm... let me see whether I can combine a non-empty undo history with the "hasUnacceptedChanges" flag. :-) Thanks for the idea.

Best,
Marcel
Am 03.12.2021 00:54:36 schrieb Chris Muller <asqueaker at gmail.com>:
Hi Marcel, 

I've experienced the situation Jakob did before and, yes, it's frustrating, but because it's extremely rare, I think this solution is worse than the problem.  I type quick expressions in code panes all the time, using Cmd+l to quickly get back the original code.  This prompt makes that use case unbearable, and I doubt it'll be effective for avoiding losing work, because the user will simply develop a habit to press Cmd+l+[Return] very quickly as a single gesture, losing their work.  

A much better solution would be for Cmd+z to simply Undo back to the last state prior to Cmd+l being pressed.  No prompt, but full control.  External text editors do this, BTW...

 - Chris


On Thu, Dec 2, 2021 at 4:42 AM Marcel Taeumel <marcel.taeumel at hpi.de [mailto:marcel.taeumel at hpi.de]> wrote:

Note that you can still have this simple, non-disrupting cancel/clear via text undo: CMD+Z

Best,
Marcel
Am 30.11.2021 23:28:45 schrieb Jakob Reschke <jakres+squeak at gmail.com [mailto:jakres%2Bsqueak at gmail.com]>:
Thank you!

Am Mo., 29. Nov. 2021 um 11:18 Uhr schrieb :
>
> Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-mt.1803.mcz [http://source.squeak.org/trunk/Morphic-mt.1803.mcz]
>
> ==================== Summary ====================
>
> Name: Morphic-mt.1803
> Author: mt
> Time: 29 November 2021, 11:17:49.411615 am
> UUID: 8dc2a08e-8d6a-40a8-9363-63825d568895
> Ancestors: Morphic-mt.1802
>
> Adds confirmation dialog to avoid inadvertent loss of unsaved work via keyboard shortcuts.
>
> The shorcut is CTRL+L, which might be triggered via CTRL+PageDown, depending on your platform and preferences.
>
> See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-November/217224.html [http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-November/217224.html]
>
> =============== Diff against Morphic-mt.1802 ===============
>
> Item was changed:
> ----- Method: TextEditor>>cancel (in category 'menu messages') -----
> cancel
> "Cancel the changes made so far to this text"
> +
> + model okToChange
> + ifTrue: [morph cancelEdits].!
> - morph cancelEdits!
>
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211203/05729b35/attachment.html>