[squeak-dev] The Trunk: System-mt.1263.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Dec 3 10:36:38 UTC 2021


Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.1263.mcz

==================== Summary ====================

Name: System-mt.1263
Author: mt
Time: 3 December 2021, 11:36:33.507016 am
UUID: 4ab14722-538d-3a4b-81a5-84ddac50ce97
Ancestors: System-mt.1262

Next iteration on information the user of conflicts with known author initials:

- Avoid suggesting "firstname.lastname" but just "a little longer" because we cannot guarantee the absence of name collisions.

- Only show the new dialog if there is any conflict.

- Do not clear the initials if you cancel the dialog.

=============== Diff against System-mt.1262 ===============

Item was changed:
  ----- Method: Utilities class>>setAuthorInitials (in category 'identification') -----
  setAuthorInitials
  	"Put up a dialog allowing the user to specify the author's initials. Inform the user about collisions with known contributors. See SystemNavigation class >> #authors. "
  
  	| newInitials newName |
  	newInitials := Project uiManager
  		request: 'Please type your initials:' translated
  		initialAnswer: AuthorInitials.
+ 	newInitials ifEmpty: [^ self "No Change"].
  
+ 	(SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames |
+ 		newName := existingNames sorted joinSeparatedBy: '/'.
- 	SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames |
- 		newName := existingNames sorted joinSeparatedBy: '/'].
  
+ 	(self confirm: ('Hello, <b>{1}</b>!! :-)<br><br><font face="{4}" size="{5}">Our <a href="code://{3}">list of known contributors</{6}> associates the initials you<br>have entered with this name. If this is not you, please<br>consider alternative initials, preferably more than just <br>a few characters, to avoid collisions.</font><br><br>Do you want to use these author initials?<br><br>	<b>{2}</b>' translated format: {
- 	(self confirm: ('Hello, <b>{1}</b>!! :-)<br><br><font face="{4}" size="{5}">Our <a href="code://{3}">list of known contributors</{6}> associates the initials you<br>have entered with this name. If this is not you, please<br>consider entering alternative initials, preferably in the<br>format <b>firstName.lastName</b> to avoid collisions.</font><br><br>Are these your author initials?<br><br>	<b>{2}</b>' translated format: {
  		newName ifNil: [newInitials].
  		newInitials.
  		'SystemReporter open model categoryAt: 1 put: true'.
  		Preferences standardButtonFont familyName.
  		Preferences standardButtonFont pointSize.
  		"mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346.html"
+ 		'a' }) asTextFromHtml) ] ifAbsent: [true])
+ 			ifTrue: [self authorInitials: newInitials].!
- 		'a' }) asTextFromHtml) 
- 
- 		ifTrue: [self authorInitials: newInitials].!



More information about the Squeak-dev mailing list