[squeak-dev] The Trunk: Morphic-mt.1773.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Jun 14 06:31:57 UTC 2021


Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1773.mcz

==================== Summary ====================

Name: Morphic-mt.1773
Author: mt
Time: 14 June 2021, 8:31:51.352374 am
UUID: d4056dd6-8c5f-e045-9c9a-b6b4b34b42a3
Ancestors: Morphic-ct.1772

Adds explanation about why not sending super in the recent selectionIndex: fix.

=============== Diff against Morphic-ct.1772 ===============

Item was changed:
  ----- Method: PluggableMultiColumnListMorph>>selectionIndex: (in category 'selection') -----
  selectionIndex: viewIndex
  
  	listMorphs do: [:listMorph | listMorph selectedRow: (viewIndex min: self listSize)].	
  	
+ 	"ct: As per the invariant defined in #setListParameters, listMorphs always includes listMorph. Subsequently, every super send in #selectionIndex: would be without effect because #selectionIndex already has been updated in the child class. Since selection highlighting is also not relevant for multi-column list morphs (this hook is only used by SimpleHierarchicalListMorph), we can refuse this bequest but send #scrollSelectionIntoView manually."
  	self scrollSelectionIntoView.!



More information about the Squeak-dev mailing list