Hi Eliot,


thanks for the fix! Sorry for raising the same question again, but wouldn't it still be safer to dispense with the #isArray call here? It allows the simulated code to break out of the simulation by overriding #isArray anywhere. I think I posted a proof of concept here: http://forum.world.st/The-Trunk-Kernel-eem-1366-mcz-tp5126558p5126713.html :-)

Best,
Christoph
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Dienstag, 2. Februar 2021 03:57:12
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Kernel-eem.1367.mcz

Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1367.mcz

==================== Summary ====================

Name: Kernel-eem.1367
Author: eem
Time: 1 February 2021, 6:57:09.713484 pm
UUID: def9aaa1-eb71-4da5-8f86-85856d9b88ad
Ancestors: Kernel-eem.1366

Fix mistake in the previous commit.  Thanks Levente!

=============== Diff against Kernel-eem.1366 ===============

Item was changed:
  ----- Method: Context>>isPrimFailToken: (in category 'private') -----
+ isPrimFailToken: contextOrPrimFailToken
+        "Answer if contextOrPrimFailToken, which will either be a Context object or
+         a primitive fail token (a tuple of the PrimitiveFailToken unique object and
+         a primitive failure code), is the latter. This should only be used with the
+         (possibly indirect) results of Context>>doPrimitive:method:receiver:args:"
+        ^contextOrPrimFailToken isArray
+          and: [contextOrPrimFailToken size = 2
+          and: [(contextOrPrimFailToken at: 1) == PrimitiveFailToken]]!
- isPrimFailToken: anObject
-        ^(self objectClass: anObject) isArray
-          and: [anObject size = 2
-          and: [(anObject at: 1) == PrimitiveFailToken]]!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210302/08428708/attachment-0001.html>